Skip to content

Commit

Permalink
V4L/DVB (13550): v4l: Use the new video_device_node_name function
Browse files Browse the repository at this point in the history
Fix all device drivers to use the new video_device_node_name function.

This also strips kernel log messages from the "/dev/" prefix, has the device
node location is a userspace policy decision unknown to the kernel.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Laurent Pinchart authored and Mauro Carvalho Chehab committed Dec 16, 2009
1 parent eac8ea5 commit 38c7c03
Show file tree
Hide file tree
Showing 37 changed files with 231 additions and 231 deletions.
12 changes: 5 additions & 7 deletions drivers/media/common/saa7146_fops.c
Original file line number Diff line number Diff line change
Expand Up @@ -543,15 +543,13 @@ int saa7146_register_device(struct video_device **vid, struct saa7146_dev* dev,
return err;
}

if( VFL_TYPE_GRABBER == type ) {
if (VFL_TYPE_GRABBER == type)
vv->video_minor = vfd->minor;
INFO(("%s: registered device video%d [v4l2]\n",
dev->name, vfd->num));
} else {
else
vv->vbi_minor = vfd->minor;
INFO(("%s: registered device vbi%d [v4l2]\n",
dev->name, vfd->num));
}

INFO(("%s: registered device %s [v4l2]\n",
dev->name, video_device_node_name(vfd)));

*vid = vfd;
return 0;
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/video/arv.c
Original file line number Diff line number Diff line change
Expand Up @@ -860,8 +860,8 @@ static int __init ar_init(void)
goto out_dev;
}

printk("video%d: Found M64278 VGA (IRQ %d, Freq %dMHz).\n",
ar->vdev->num, M32R_IRQ_INT3, freq);
printk("%s: Found M64278 VGA (IRQ %d, Freq %dMHz).\n",
video_device_node_name(ar->vdev), M32R_IRQ_INT3, freq);

return 0;

Expand Down
12 changes: 6 additions & 6 deletions drivers/media/video/bt8xx/bttv-driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -4244,8 +4244,8 @@ static int __devinit bttv_register_video(struct bttv *btv)
if (video_register_device(btv->video_dev, VFL_TYPE_GRABBER,
video_nr[btv->c.nr]) < 0)
goto err;
printk(KERN_INFO "bttv%d: registered device video%d\n",
btv->c.nr, btv->video_dev->num);
printk(KERN_INFO "bttv%d: registered device %s\n",
btv->c.nr, video_device_node_name(btv->video_dev));
if (device_create_file(&btv->video_dev->dev,
&dev_attr_card)<0) {
printk(KERN_ERR "bttv%d: device_create_file 'card' "
Expand All @@ -4261,8 +4261,8 @@ static int __devinit bttv_register_video(struct bttv *btv)
if (video_register_device(btv->vbi_dev, VFL_TYPE_VBI,
vbi_nr[btv->c.nr]) < 0)
goto err;
printk(KERN_INFO "bttv%d: registered device vbi%d\n",
btv->c.nr, btv->vbi_dev->num);
printk(KERN_INFO "bttv%d: registered device %s\n",
btv->c.nr, video_device_node_name(btv->vbi_dev));

if (!btv->has_radio)
return 0;
Expand All @@ -4273,8 +4273,8 @@ static int __devinit bttv_register_video(struct bttv *btv)
if (video_register_device(btv->radio_dev, VFL_TYPE_RADIO,
radio_nr[btv->c.nr]) < 0)
goto err;
printk(KERN_INFO "bttv%d: registered device radio%d\n",
btv->c.nr, btv->radio_dev->num);
printk(KERN_INFO "bttv%d: registered device %s\n",
btv->c.nr, video_device_node_name(btv->radio_dev));

/* all done */
return 0;
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/video/c-qcam.c
Original file line number Diff line number Diff line change
Expand Up @@ -809,8 +809,8 @@ static int init_cqcam(struct parport *port)
return -ENODEV;
}

printk(KERN_INFO "video%d: Colour QuickCam found on %s\n",
qcam->vdev.num, qcam->pport->name);
printk(KERN_INFO "%s: Colour QuickCam found on %s\n",
video_device_node_name(&qcam->vdev), qcam->pport->name);

qcams[num_cams++] = qcam;

Expand Down
13 changes: 4 additions & 9 deletions drivers/media/video/cpia.c
Original file line number Diff line number Diff line change
Expand Up @@ -1342,15 +1342,13 @@ static int cpia_write_proc(struct file *file, const char __user *buf,

static void create_proc_cpia_cam(struct cam_data *cam)
{
char name[5 + 1 + 10 + 1];
struct proc_dir_entry *ent;

if (!cpia_proc_root || !cam)
return;

snprintf(name, sizeof(name), "video%d", cam->vdev.num);

ent = create_proc_entry(name, S_IFREG|S_IRUGO|S_IWUSR, cpia_proc_root);
ent = create_proc_entry(video_device_node_name(&cam->vdev),
S_IFREG|S_IRUGO|S_IWUSR, cpia_proc_root);
if (!ent)
return;

Expand All @@ -1368,13 +1366,10 @@ static void create_proc_cpia_cam(struct cam_data *cam)

static void destroy_proc_cpia_cam(struct cam_data *cam)
{
char name[5 + 1 + 10 + 1];

if (!cam || !cam->proc_entry)
return;

snprintf(name, sizeof(name), "video%d", cam->vdev.num);
remove_proc_entry(name, cpia_proc_root);
remove_proc_entry(video_device_node_name(&cam->vdev), cpia_proc_root);
cam->proc_entry = NULL;
}

Expand Down Expand Up @@ -3999,7 +3994,7 @@ void cpia_unregister_camera(struct cam_data *cam)
}

#ifdef CONFIG_PROC_FS
DBG("destroying /proc/cpia/video%d\n", cam->vdev.num);
DBG("destroying /proc/cpia/%s\n", video_device_node_name(&cam->vdev));
destroy_proc_cpia_cam(cam);
#endif
if (!cam->open_count) {
Expand Down
6 changes: 3 additions & 3 deletions drivers/media/video/cpia2/cpia2_v4l.c
Original file line number Diff line number Diff line change
Expand Up @@ -1967,9 +1967,9 @@ void cpia2_unregister_camera(struct camera_data *cam)
if (!cam->open_count) {
video_unregister_device(cam->vdev);
} else {
LOG("/dev/video%d removed while open, "
"deferring video_unregister_device\n",
cam->vdev->num);
LOG("%s removed while open, deferring "
"video_unregister_device\n",
video_device_node_name(cam->vdev));
}
}

Expand Down
20 changes: 10 additions & 10 deletions drivers/media/video/cx18/cx18-streams.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ static int cx18_reg_dev(struct cx18 *cx, int type)
{
struct cx18_stream *s = &cx->streams[type];
int vfl_type = cx18_stream_info[type].vfl_type;
const char *name;
int num, ret;

/* TODO: Shouldn't this be a VFL_TYPE_TRANSPORT or something?
Expand Down Expand Up @@ -258,31 +259,30 @@ static int cx18_reg_dev(struct cx18 *cx, int type)
s->video_dev = NULL;
return ret;
}
num = s->video_dev->num;

name = video_device_node_name(s->video_dev);

switch (vfl_type) {
case VFL_TYPE_GRABBER:
CX18_INFO("Registered device video%d for %s "
"(%d x %d.%02d kB)\n",
num, s->name, cx->stream_buffers[type],
CX18_INFO("Registered device %s for %s (%d x %d.%02d kB)\n",
name, s->name, cx->stream_buffers[type],
cx->stream_buf_size[type] / 1024,
(cx->stream_buf_size[type] * 100 / 1024) % 100);
break;

case VFL_TYPE_RADIO:
CX18_INFO("Registered device radio%d for %s\n",
num, s->name);
CX18_INFO("Registered device %s for %s\n", name, s->name);
break;

case VFL_TYPE_VBI:
if (cx->stream_buffers[type])
CX18_INFO("Registered device vbi%d for %s "
CX18_INFO("Registered device %s for %s "
"(%d x %d bytes)\n",
num, s->name, cx->stream_buffers[type],
name, s->name, cx->stream_buffers[type],
cx->stream_buf_size[type]);
else
CX18_INFO("Registered device vbi%d for %s\n",
num, s->name);
CX18_INFO("Registered device %s for %s\n",
name, s->name);
break;
}

Expand Down
5 changes: 3 additions & 2 deletions drivers/media/video/cx231xx/cx231xx-cards.c
Original file line number Diff line number Diff line change
Expand Up @@ -856,8 +856,9 @@ static void cx231xx_usb_disconnect(struct usb_interface *interface)

if (dev->users) {
cx231xx_warn
("device /dev/video%d is open! Deregistration and memory "
"deallocation are deferred on close.\n", dev->vdev->num);
("device %s is open! Deregistration and memory "
"deallocation are deferred on close.\n",
video_device_node_name(dev->vdev));

dev->state |= DEV_MISCONFIGURED;
cx231xx_uninit_isoc(dev);
Expand Down
25 changes: 13 additions & 12 deletions drivers/media/video/cx231xx/cx231xx-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -2027,17 +2027,17 @@ void cx231xx_release_analog_resources(struct cx231xx *dev)
dev->radio_dev = NULL;
}
if (dev->vbi_dev) {
cx231xx_info("V4L2 device /dev/vbi%d deregistered\n",
dev->vbi_dev->num);
cx231xx_info("V4L2 device %s deregistered\n",
video_device_node_name(dev->vbi_dev));
if (-1 != dev->vbi_dev->minor)
video_unregister_device(dev->vbi_dev);
else
video_device_release(dev->vbi_dev);
dev->vbi_dev = NULL;
}
if (dev->vdev) {
cx231xx_info("V4L2 device /dev/video%d deregistered\n",
dev->vdev->num);
cx231xx_info("V4L2 device %s deregistered\n",
video_device_node_name(dev->vdev));
if (-1 != dev->vdev->minor)
video_unregister_device(dev->vdev);
else
Expand Down Expand Up @@ -2374,8 +2374,8 @@ int cx231xx_register_analog_devices(struct cx231xx *dev)
return ret;
}

cx231xx_info("%s/0: registered device video%d [v4l2]\n",
dev->name, dev->vdev->num);
cx231xx_info("%s/0: registered device %s [v4l2]\n",
dev->name, video_device_node_name(dev->vdev));

/* Initialize VBI template */
memcpy(&cx231xx_vbi_template, &cx231xx_video_template,
Expand All @@ -2393,8 +2393,8 @@ int cx231xx_register_analog_devices(struct cx231xx *dev)
return ret;
}

cx231xx_info("%s/0: registered device vbi%d\n",
dev->name, dev->vbi_dev->num);
cx231xx_info("%s/0: registered device %s\n",
dev->name, video_device_node_name(dev->vbi_dev));

if (cx231xx_boards[dev->model].radio.type == CX231XX_RADIO) {
dev->radio_dev = cx231xx_vdev_init(dev, &cx231xx_radio_template,
Expand All @@ -2409,12 +2409,13 @@ int cx231xx_register_analog_devices(struct cx231xx *dev)
cx231xx_errdev("can't register radio device\n");
return ret;
}
cx231xx_info("Registered radio device as /dev/radio%d\n",
dev->radio_dev->num);
cx231xx_info("Registered radio device as %s\n",
video_device_node_name(dev->radio_dev));
}

cx231xx_info("V4L2 device registered as /dev/video%d and /dev/vbi%d\n",
dev->vdev->num, dev->vbi_dev->num);
cx231xx_info("V4L2 device registered as %s and %s\n",
video_device_node_name(dev->vdev),
video_device_node_name(dev->vbi_dev));

return 0;
}
4 changes: 2 additions & 2 deletions drivers/media/video/cx23885/cx23885-417.c
Original file line number Diff line number Diff line change
Expand Up @@ -1810,8 +1810,8 @@ int cx23885_417_register(struct cx23885_dev *dev)
return err;
}

printk(KERN_INFO "%s: registered device video%d [mpeg]\n",
dev->name, dev->v4l_device->num);
printk(KERN_INFO "%s: registered device %s [mpeg]\n",
dev->name, video_device_node_name(dev->v4l_device));

return 0;
}
4 changes: 2 additions & 2 deletions drivers/media/video/cx23885/cx23885-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -1532,8 +1532,8 @@ int cx23885_video_register(struct cx23885_dev *dev)
dev->name);
goto fail_unreg;
}
printk(KERN_INFO "%s/0: registered device video%d [v4l2]\n",
dev->name, dev->video_dev->num);
printk(KERN_INFO "%s/0: registered device %s [v4l2]\n",
dev->name, video_device_node_name(dev->video_dev));
/* initial device configuration */
mutex_lock(&dev->lock);
cx23885_set_tvnorm(dev, dev->tvnorm);
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/video/cx88/cx88-blackbird.c
Original file line number Diff line number Diff line change
Expand Up @@ -1296,8 +1296,8 @@ static int blackbird_register_video(struct cx8802_dev *dev)
dev->core->name);
return err;
}
printk(KERN_INFO "%s/2: registered device video%d [mpeg]\n",
dev->core->name, dev->mpeg_dev->num);
printk(KERN_INFO "%s/2: registered device %s [mpeg]\n",
dev->core->name, video_device_node_name(dev->mpeg_dev));
return 0;
}

Expand Down
12 changes: 6 additions & 6 deletions drivers/media/video/cx88/cx88-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -1916,8 +1916,8 @@ static int __devinit cx8800_initdev(struct pci_dev *pci_dev,
core->name);
goto fail_unreg;
}
printk(KERN_INFO "%s/0: registered device video%d [v4l2]\n",
core->name, dev->video_dev->num);
printk(KERN_INFO "%s/0: registered device %s [v4l2]\n",
core->name, video_device_node_name(dev->video_dev));

dev->vbi_dev = cx88_vdev_init(core,dev->pci,&cx8800_vbi_template,"vbi");
err = video_register_device(dev->vbi_dev,VFL_TYPE_VBI,
Expand All @@ -1927,8 +1927,8 @@ static int __devinit cx8800_initdev(struct pci_dev *pci_dev,
core->name);
goto fail_unreg;
}
printk(KERN_INFO "%s/0: registered device vbi%d\n",
core->name, dev->vbi_dev->num);
printk(KERN_INFO "%s/0: registered device %s\n",
core->name, video_device_node_name(dev->vbi_dev));

if (core->board.radio.type == CX88_RADIO) {
dev->radio_dev = cx88_vdev_init(core,dev->pci,
Expand All @@ -1940,8 +1940,8 @@ static int __devinit cx8800_initdev(struct pci_dev *pci_dev,
core->name);
goto fail_unreg;
}
printk(KERN_INFO "%s/0: registered device radio%d\n",
core->name, dev->radio_dev->num);
printk(KERN_INFO "%s/0: registered device %s\n",
core->name, video_device_node_name(dev->radio_dev));
}

/* everything worked */
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/video/em28xx/em28xx-cards.c
Original file line number Diff line number Diff line change
Expand Up @@ -2923,9 +2923,9 @@ static void em28xx_usb_disconnect(struct usb_interface *interface)

if (dev->users) {
em28xx_warn
("device /dev/video%d is open! Deregistration and memory "
("device %s is open! Deregistration and memory "
"deallocation are deferred on close.\n",
dev->vdev->num);
video_device_node_name(dev->vdev));

dev->state |= DEV_MISCONFIGURED;
em28xx_uninit_isoc(dev);
Expand Down
20 changes: 10 additions & 10 deletions drivers/media/video/em28xx/em28xx-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -2167,17 +2167,17 @@ void em28xx_release_analog_resources(struct em28xx *dev)
dev->radio_dev = NULL;
}
if (dev->vbi_dev) {
em28xx_info("V4L2 device /dev/vbi%d deregistered\n",
dev->vbi_dev->num);
em28xx_info("V4L2 device %s deregistered\n",
video_device_node_name(dev->vbi_dev));
if (-1 != dev->vbi_dev->minor)
video_unregister_device(dev->vbi_dev);
else
video_device_release(dev->vbi_dev);
dev->vbi_dev = NULL;
}
if (dev->vdev) {
em28xx_info("V4L2 device /dev/video%d deregistered\n",
dev->vdev->num);
em28xx_info("V4L2 device %s deregistered\n",
video_device_node_name(dev->vdev));
if (-1 != dev->vdev->minor)
video_unregister_device(dev->vdev);
else
Expand Down Expand Up @@ -2540,16 +2540,16 @@ int em28xx_register_analog_devices(struct em28xx *dev)
em28xx_errdev("can't register radio device\n");
return ret;
}
em28xx_info("Registered radio device as /dev/radio%d\n",
dev->radio_dev->num);
em28xx_info("Registered radio device as %s\n",
video_device_node_name(dev->radio_dev));
}

em28xx_info("V4L2 video device registered as /dev/video%d\n",
dev->vdev->num);
em28xx_info("V4L2 video device registered as %s\n",
video_device_node_name(dev->vdev));

if (dev->vbi_dev)
em28xx_info("V4L2 VBI device registered as /dev/vbi%d\n",
dev->vbi_dev->num);
em28xx_info("V4L2 VBI device registered as %s\n",
video_device_node_name(dev->vbi_dev));

return 0;
}
Loading

0 comments on commit 38c7c03

Please sign in to comment.