Skip to content

Commit

Permalink
sony-laptop: brightness regression fix
Browse files Browse the repository at this point in the history
After commit 540b8bb:

  sony-laptop: fingers off backlight if video.ko is serving this functionality

I can't set brightness on my sony laptop (nothing in /sys/class/backlight).
dmesg says "sony-laptop: Sony: Brightness ignored, must be controlled by ACPI
video driver".

The function acpi_video_backlight_support returns 0 if we should use the
vendor-specific backlight support, while non-0 if the ACPI generic should
be used. Because of this, the check introduced by the said commit appears
reversed.

Signed-off-by: Alessandro Guido <ag@alessandroguido.name>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Alessandro Guido authored and Len Brown committed Nov 26, 2008
1 parent 3bdca1b commit 38cfc14
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/misc/sony-laptop.c
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,7 @@ static int sony_nc_add(struct acpi_device *device)
goto outinput;
}

if (!acpi_video_backlight_support()) {
if (acpi_video_backlight_support()) {
printk(KERN_INFO DRV_PFX "Sony: Brightness ignored, must be "
"controlled by ACPI video driver\n");
} else if (ACPI_SUCCESS(acpi_get_handle(sony_nc_acpi_handle, "GBRT",
Expand Down

0 comments on commit 38cfc14

Please sign in to comment.