Skip to content

Commit

Permalink
staging: comedi: me4000: remove PORT_PDEBUG macro
Browse files Browse the repository at this point in the history
The PORT_PDEBUG macro is used to output the result of every port
io operation. This shouldn't be in a mainline driver. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jun 15, 2012
1 parent 1d489ba commit 3934954
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
4 changes: 0 additions & 4 deletions drivers/staging/comedi/drivers/me4000.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,12 @@ static int ai_write_chanlist(struct comedi_device *dev,
static inline void me4000_outb(struct comedi_device *dev, unsigned char value,
unsigned long port)
{
PORT_PDEBUG("--> 0x%02X port 0x%04lX\n", value, port);
outb(value, port);
}

static inline void me4000_outl(struct comedi_device *dev, unsigned long value,
unsigned long port)
{
PORT_PDEBUG("--> 0x%08lX port 0x%04lX\n", value, port);
outl(value, port);
}

Expand All @@ -127,7 +125,6 @@ static inline unsigned long me4000_inl(struct comedi_device *dev,
{
unsigned long value;
value = inl(port);
PORT_PDEBUG("<-- 0x%08lX port 0x%04lX\n", value, port);
return value;
}

Expand All @@ -136,7 +133,6 @@ static inline unsigned char me4000_inb(struct comedi_device *dev,
{
unsigned char value;
value = inb(port);
PORT_PDEBUG("<-- 0x%08X port 0x%04lX\n", value, port);
return value;
}

Expand Down
8 changes: 0 additions & 8 deletions drivers/staging/comedi/drivers/me4000.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,9 @@
Debug section
===========================================================================*/

#undef ME4000_PORT_DEBUG /* Debug port access */
#undef ME4000_ISR_DEBUG /* Debug the interrupt service routine */
#undef ME4000_DEBUG /* General purpose debug masseges */

#ifdef ME4000_PORT_DEBUG
#undef PORT_PDEBUG
#define PORT_PDEBUG(fmt, args...) printk(KERN_DEBUG"comedi%d: me4000: " fmt, dev->minor, ##args)
#else
#define PORT_PDEBUG(fmt, args...) /* no debugging, do nothing */
#endif

#ifdef ME4000_ISR_DEBUG
#undef ISR_PDEBUG
#define ISR_PDEBUG(fmt, args...) printk(KERN_DEBUG"comedi%d: me4000: " fmt, dev->minor, ##args)
Expand Down

0 comments on commit 3934954

Please sign in to comment.