Skip to content

Commit

Permalink
pppoatm: do not inline pppoatm_may_send()
Browse files Browse the repository at this point in the history
The pppoatm_may_send() is quite heavy and it's called three times
in pppoatm_send() and inlining costs more than 200 bytes of code
(more than 10% of total pppoatm driver code size).

add/remove: 1/0 grow/shrink: 0/1 up/down: 132/-367 (-235)
function                                     old     new   delta
pppoatm_may_send                               -     132    +132
pppoatm_send                                 900     533    -367

Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
  • Loading branch information
Krzysztof Mazur authored and David Woodhouse committed Nov 30, 2012
1 parent 071d939 commit 397ff16
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/atm/pppoatm.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ static void pppoatm_push(struct atm_vcc *atmvcc, struct sk_buff *skb)
ppp_input_error(&pvcc->chan, 0);
}

static inline int pppoatm_may_send(struct pppoatm_vcc *pvcc, int size)
static int pppoatm_may_send(struct pppoatm_vcc *pvcc, int size)
{
/*
* It's not clear that we need to bother with using atm_may_send()
Expand Down

0 comments on commit 397ff16

Please sign in to comment.