Skip to content

Commit

Permalink
asm-generic/vmlinux.lds.h: shuffle INIT_TASK* macro names in vmlinux.…
Browse files Browse the repository at this point in the history
…lds.h

We recently added a INIT_TASK(align) in include/asm-generic/vmlinux.lds.h,
but there is already a macro INIT_TASK in include/linux/init_task.h, which
is quite confusing.  We should switch the macro in the linker script to
INIT_TASK_DATA. (Sorry that I missed this in reviewing the patch).  Since
the macros are new, there is only one user of the INIT_TASK in
vmlinux.lds.h, arch/mn10300/kernel/vmlinux.lds.S.

However, we are currently using INIT_TASK_DATA for laying down an entire
.data.init_task section.  So rename that to INIT_TASK_DATA_SECTION.

I would be worried about changing the meaning of INIT_TASK_DATA, but the
old INIT_TASK_DATA implementation had no users, and in fact if anyone had
tried to use it, it would have failed to compile because it didn't pass
the alignment to the old INIT_TASK.

Signed-off-by: Tim Abbott <tabbott@ksplice.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Jesper Nilsson <Jesper.Nilsson@axis.com
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
  • Loading branch information
Tim Abbott authored and Sam Ravnborg committed Jun 26, 2009
1 parent d2af12a commit 39a449d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion arch/mn10300/kernel/vmlinux.lds.S
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ SECTIONS
_edata = .; /* End of data section */
}

.data.init_task : { INIT_TASK(THREAD_SIZE); }
.data.init_task : { INIT_TASK_DATA(THREAD_SIZE); }

/* might get freed after init */
. = ALIGN(PAGE_SIZE);
Expand Down
8 changes: 4 additions & 4 deletions include/asm-generic/vmlinux.lds.h
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@
. = ALIGN(align); \
*(.data.cacheline_aligned)

#define INIT_TASK(align) \
#define INIT_TASK_DATA(align) \
. = ALIGN(align); \
*(.data.init_task)

Expand Down Expand Up @@ -434,10 +434,10 @@
/*
* Init task
*/
#define INIT_TASK_DATA(align) \
#define INIT_TASK_DATA_SECTION(align) \
. = ALIGN(align); \
.data.init_task : { \
INIT_TASK \
INIT_TASK_DATA(align) \
}

#ifdef CONFIG_CONSTRUCTORS
Expand Down Expand Up @@ -707,7 +707,7 @@
#define RW_DATA_SECTION(cacheline, pagealigned, inittask) \
. = ALIGN(PAGE_SIZE); \
.data : AT(ADDR(.data) - LOAD_OFFSET) { \
INIT_TASK(inittask) \
INIT_TASK_DATA(inittask) \
CACHELINE_ALIGNED_DATA(cacheline) \
READ_MOSTLY_DATA(cacheline) \
DATA_DATA \
Expand Down

0 comments on commit 39a449d

Please sign in to comment.