Skip to content

Commit

Permalink
[PATCH] futex: remove duplicate code
Browse files Browse the repository at this point in the history
This patch cleans up the error path of futex_fd() by removing duplicate
code.

Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Pekka Enberg authored and Linus Torvalds committed Sep 7, 2005
1 parent 580b2e3 commit 39ed3fd
Showing 1 changed file with 9 additions and 12 deletions.
21 changes: 9 additions & 12 deletions kernel/futex.c
Original file line number Diff line number Diff line change
Expand Up @@ -786,34 +786,26 @@ static int futex_fd(unsigned long uaddr, int signal)
filp->f_mapping = filp->f_dentry->d_inode->i_mapping;

if (signal) {
int err;
err = f_setown(filp, current->pid, 1);
if (err < 0) {
put_unused_fd(ret);
put_filp(filp);
ret = err;
goto out;
goto error;
}
filp->f_owner.signum = signal;
}

q = kmalloc(sizeof(*q), GFP_KERNEL);
if (!q) {
put_unused_fd(ret);
put_filp(filp);
ret = -ENOMEM;
goto out;
err = -ENOMEM;
goto error;
}

down_read(&current->mm->mmap_sem);
err = get_futex_key(uaddr, &q->key);

if (unlikely(err != 0)) {
up_read(&current->mm->mmap_sem);
put_unused_fd(ret);
put_filp(filp);
kfree(q);
return err;
goto error;
}

/*
Expand All @@ -829,6 +821,11 @@ static int futex_fd(unsigned long uaddr, int signal)
fd_install(ret, filp);
out:
return ret;
error:
put_unused_fd(ret);
put_filp(filp);
ret = err;
goto out;
}

long do_futex(unsigned long uaddr, int op, int val, unsigned long timeout,
Expand Down

0 comments on commit 39ed3fd

Please sign in to comment.