Skip to content

Commit

Permalink
staging: comedi: cb_pcidio: remove thisboard macro
Browse files Browse the repository at this point in the history
This macro relies on a local variable having a specific name.
Remove it and use the comedi_board() helper to get the pointer.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Aug 17, 2012
1 parent 3b96f25 commit 39ffddb
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions drivers/staging/comedi/drivers/cb_pcidio.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,6 @@ static const struct pcidio_board pcidio_boards[] = {
},
};

/*
* Useful for shorthand access to the particular board structure
*/
#define thisboard ((const struct pcidio_board *)dev->board_ptr)

static struct pci_dev *pcidio_find_pci_dev(struct comedi_device *dev,
struct comedi_devconfig *it)
{
Expand Down Expand Up @@ -122,6 +117,7 @@ static struct pci_dev *pcidio_find_pci_dev(struct comedi_device *dev,

static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
{
const struct pcidio_board *thisboard;
struct pci_dev *pcidev;
int i;
int ret;
Expand All @@ -130,11 +126,7 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
if (!pcidev)
return -EIO;
comedi_set_hw_dev(dev, &pcidev->dev);

/*
* Initialize dev->board_name. Note that we can use the "thisboard"
* macro now, since we just initialized it in the last line.
*/
thisboard = comedi_board(dev);
dev->board_name = thisboard->name;

if (comedi_pci_enable(pcidev, thisboard->name))
Expand All @@ -158,6 +150,7 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)

static void pcidio_detach(struct comedi_device *dev)
{
const struct pcidio_board *thisboard = comedi_board(dev);
struct pci_dev *pcidev = comedi_to_pci_dev(dev);

if (pcidev) {
Expand Down

0 comments on commit 39ffddb

Please sign in to comment.