Skip to content

Commit

Permalink
drm/i915: shorten debugfs output simple attributes
Browse files Browse the repository at this point in the history
commit 647416f
Author: Kees Cook <keescook@chromium.org>
Date:   Sun Mar 10 14:10:06 2013 -0700

    drm/i915: use simple attribute in debugfs routines

made i915_next_seqno debugfs entry to crop it's output
if returned value was large enough. Using simple_attr
will limit the output to 24 bytes.

Fix is to strip out preamples on all simple attributes
that have one.

v2: Fix all simple attributes (Daniel Vetter)

Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Mika Kuoppala authored and Daniel Vetter committed Apr 18, 2013
1 parent 87476d6 commit 3a3b4f9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/gpu/drm/i915/i915_debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,7 @@ i915_next_seqno_set(void *data, u64 val)

DEFINE_SIMPLE_ATTRIBUTE(i915_next_seqno_fops,
i915_next_seqno_get, i915_next_seqno_set,
"next_seqno : 0x%llx\n");
"0x%llx\n");

static int i915_rstdby_delays(struct seq_file *m, void *unused)
{
Expand Down Expand Up @@ -1690,7 +1690,7 @@ i915_wedged_set(void *data, u64 val)

DEFINE_SIMPLE_ATTRIBUTE(i915_wedged_fops,
i915_wedged_get, i915_wedged_set,
"wedged : %llu\n");
"%llu\n");

static int
i915_ring_stop_get(void *data, u64 *val)
Expand Down Expand Up @@ -1844,7 +1844,7 @@ i915_max_freq_set(void *data, u64 val)

DEFINE_SIMPLE_ATTRIBUTE(i915_max_freq_fops,
i915_max_freq_get, i915_max_freq_set,
"max freq: %llu\n");
"%llu\n");

static int
i915_min_freq_get(void *data, u64 *val)
Expand Down Expand Up @@ -1895,7 +1895,7 @@ i915_min_freq_set(void *data, u64 val)

DEFINE_SIMPLE_ATTRIBUTE(i915_min_freq_fops,
i915_min_freq_get, i915_min_freq_set,
"min freq: %llu\n");
"%llu\n");

static int
i915_cache_sharing_get(void *data, u64 *val)
Expand Down

0 comments on commit 3a3b4f9

Please sign in to comment.