Skip to content

Commit

Permalink
BUG_ON() Conversion in drivers/s390/char/tape_block.c
Browse files Browse the repository at this point in the history
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
  • Loading branch information
Eric Sesterhenn authored and Adrian Bunk committed Mar 31, 2006
1 parent e048a8a commit 3a8dc89
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions drivers/s390/char/tape_block.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,7 @@ tapeblock_request_fn(request_queue_t *queue)

device = (struct tape_device *) queue->queuedata;
DBF_LH(6, "tapeblock_request_fn(device=%p)\n", device);
if (device == NULL)
BUG();

BUG_ON(device == NULL);
tapeblock_trigger_requeue(device);
}

Expand Down Expand Up @@ -307,8 +305,7 @@ tapeblock_revalidate_disk(struct gendisk *disk)
int rc;

device = (struct tape_device *) disk->private_data;
if (!device)
BUG();
BUG_ON(!device);

if (!device->blk_data.medium_changed)
return 0;
Expand Down Expand Up @@ -440,11 +437,9 @@ tapeblock_ioctl(

rc = 0;
disk = inode->i_bdev->bd_disk;
if (!disk)
BUG();
BUG_ON(!disk);
device = disk->private_data;
if (!device)
BUG();
BUG_ON(!device);
minor = iminor(inode);

DBF_LH(6, "tapeblock_ioctl(0x%0x)\n", command);
Expand Down

0 comments on commit 3a8dc89

Please sign in to comment.