Skip to content

Commit

Permalink
x86/reboot: Update nonmi_ipi parameter
Browse files Browse the repository at this point in the history
Update the nonmi_ipi parameter to reflect the simple change
instead of the previous complicated one.  There should be less
of a need to use it but there may still be corner cases on older
hardware that stumble into NMI issues.

Signed-off-by: Don Zickus <dzickus@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1336761675-24296-4-git-send-email-dzickus@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Don Zickus authored and Ingo Molnar committed May 14, 2012
1 parent 7d007d2 commit 3aac27a
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions arch/x86/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
*/

static atomic_t stopping_cpu = ATOMIC_INIT(-1);
static bool smp_no_nmi_ipi = false;

/*
* this function sends a 'reschedule' IPI to another CPU.
Expand Down Expand Up @@ -216,7 +217,7 @@ static void native_stop_other_cpus(int wait)
}

/* if the REBOOT_VECTOR didn't work, try with the NMI */
if ((num_online_cpus() > 1)) {
if ((num_online_cpus() > 1) && (!smp_no_nmi_ipi)) {
if (register_nmi_handler(NMI_LOCAL, smp_stop_nmi_callback,
NMI_FLAG_FIRST, "smp_stop"))
/* Note: we ignore failures here */
Expand Down Expand Up @@ -245,11 +246,6 @@ static void native_stop_other_cpus(int wait)
local_irq_restore(flags);
}

static void native_smp_disable_nmi_ipi(void)
{
smp_ops.stop_other_cpus = native_irq_stop_other_cpus;
}

/*
* Reschedule call back.
*/
Expand Down Expand Up @@ -283,8 +279,8 @@ void smp_call_function_single_interrupt(struct pt_regs *regs)

static int __init nonmi_ipi_setup(char *str)
{
native_smp_disable_nmi_ipi();
return 1;
smp_no_nmi_ipi = true;
return 1;
}

__setup("nonmi_ipi", nonmi_ipi_setup);
Expand Down

0 comments on commit 3aac27a

Please sign in to comment.