Skip to content

Commit

Permalink
[ARM] S3C: Do not set clk->owner field if unset
Browse files Browse the repository at this point in the history
The s3c24xx_register_clock() function has been doing a test
on clk->owner to see if it is NULL, and then setting itself
as the owner if clk->owner == NULL.

This is not needed, arch/arm/plat-s3c/clock.c cannot be
compiled as a module, and even if it was, it should not be
playing with this field if it being registered from somewhere
else.

The best course of action is to remove this bit of
code completely.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
  • Loading branch information
Ben Dooks committed May 15, 2009
1 parent a8af6de commit 3ac19bb
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions arch/arm/plat-s3c/clock.c
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,6 @@ struct clk s3c24xx_uclk = {

int s3c24xx_register_clock(struct clk *clk)
{
clk->owner = THIS_MODULE;

if (clk->enable == NULL)
clk->enable = clk_null_enable;

Expand Down

0 comments on commit 3ac19bb

Please sign in to comment.