Skip to content

Commit

Permalink
thermal: exynos: Miscellaneous fixes to support falling threshold int…
Browse files Browse the repository at this point in the history
…errupt

Below fixes are done to support falling threshold interrupt,
* Falling interrupt status macro corrected according to exynos5 data sheet.
* The get trend function modified to calculate trip temperature correctly.
* The clearing of interrupt status in the isr is now done after handling
  the event that caused the interrupt.

Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
  • Loading branch information
Amit Daniel Kachhap authored and Zhang Rui committed Feb 6, 2013
1 parent d6d71ee commit 3ad9524
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions drivers/thermal/exynos_thermal.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@

#define EXYNOS_TRIMINFO_RELOAD 0x1
#define EXYNOS_TMU_CLEAR_RISE_INT 0x111
#define EXYNOS_TMU_CLEAR_FALL_INT (0x111 << 16)
#define EXYNOS_TMU_CLEAR_FALL_INT (0x111 << 12)
#define EXYNOS_MUX_ADDR_VALUE 6
#define EXYNOS_MUX_ADDR_SHIFT 20
#define EXYNOS_TMU_TRIP_MODE_SHIFT 13
Expand Down Expand Up @@ -370,7 +370,14 @@ static int exynos_get_temp(struct thermal_zone_device *thermal,
static int exynos_get_trend(struct thermal_zone_device *thermal,
int trip, enum thermal_trend *trend)
{
if (thermal->temperature >= trip)
int ret;
unsigned long trip_temp;

ret = exynos_get_trip_temp(thermal, trip, &trip_temp);
if (ret < 0)
return ret;

if (thermal->temperature >= trip_temp)
*trend = THERMAL_TREND_RAISING;
else
*trend = THERMAL_TREND_DROPPING;
Expand Down Expand Up @@ -705,20 +712,18 @@ static void exynos_tmu_work(struct work_struct *work)
struct exynos_tmu_data *data = container_of(work,
struct exynos_tmu_data, irq_work);

exynos_report_trigger();
mutex_lock(&data->lock);
clk_enable(data->clk);


if (data->soc == SOC_ARCH_EXYNOS)
writel(EXYNOS_TMU_CLEAR_RISE_INT,
data->base + EXYNOS_TMU_REG_INTCLEAR);
else
writel(EXYNOS4210_TMU_INTCLEAR_VAL,
data->base + EXYNOS_TMU_REG_INTCLEAR);

clk_disable(data->clk);
mutex_unlock(&data->lock);
exynos_report_trigger();

enable_irq(data->irq);
}

Expand Down

0 comments on commit 3ad9524

Please sign in to comment.