Skip to content

Commit

Permalink
nfsd4: track recall retries in nfs4_delegation
Browse files Browse the repository at this point in the history
Move this out of a local variable into the nfs4_delegation object in
preparation for making this an async rpc call (at which point we'll need
any state like this in a common object that's preserved across function
calls).

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
  • Loading branch information
J. Bruce Fields committed May 2, 2009
1 parent 6707bd3 commit 3aea09d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/nfsd/nfs4callback.c
Original file line number Diff line number Diff line change
Expand Up @@ -507,11 +507,11 @@ nfsd4_cb_recall(struct nfs4_delegation *dp)
.rpc_argp = dp,
.rpc_cred = clp->cl_cb_conn.cb_cred
};
int retries = 1;
int status = 0;

dp->dl_retries = 1;
status = rpc_call_sync(clnt, &msg, RPC_TASK_SOFT);
while (retries--) {
while (dp->dl_retries--) {
switch (status) {
case -EIO:
/* Network partition? */
Expand Down
1 change: 1 addition & 0 deletions include/linux/nfsd/state.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ struct nfs4_delegation {
u32 dl_ident;
stateid_t dl_stateid;
struct knfsd_fh dl_fh;
int dl_retries;
};

/* client delegation callback info */
Expand Down

0 comments on commit 3aea09d

Please sign in to comment.