Skip to content

Commit

Permalink
Bluetooth: Optimize SREJ_QUEUE append
Browse files Browse the repository at this point in the history
When the I-frame received is the expected, i.e., its tx_seq is equal to
expected_tx_seq and we are under a SREJ, we can just add it to the tail
of the list. Doing that we change the complexity from O(n) to O(1).

Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
Reviewed-by: João Paulo Rechi Vita <jprvita@profusion.mobi>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
  • Loading branch information
Gustavo F. Padovan authored and Marcel Holtmann committed May 10, 2010
1 parent 812e737 commit 3b1a9f3
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion net/bluetooth/l2cap.c
Original file line number Diff line number Diff line change
Expand Up @@ -3542,7 +3542,9 @@ static inline int l2cap_data_channel_iframe(struct sock *sk, u16 rx_control, str
pi->expected_tx_seq = (pi->expected_tx_seq + 1) % 64;

if (pi->conn_state & L2CAP_CONN_SREJ_SENT) {
l2cap_add_to_srej_queue(sk, skb, tx_seq, sar);
bt_cb(skb)->tx_seq = tx_seq;
bt_cb(skb)->sar = sar;
__skb_queue_tail(SREJ_QUEUE(sk), skb);
return 0;
}

Expand Down

0 comments on commit 3b1a9f3

Please sign in to comment.