Skip to content

Commit

Permalink
x86: always enable irqs when entering idle
Browse files Browse the repository at this point in the history
This matches x86_64 behaviour, which is a superior one IMHO

Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Glauber de Oliveira Costa authored and Ingo Molnar committed Apr 17, 2008
1 parent 1d89a7f commit 3b22ec7
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions arch/x86/kernel/process_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ void default_idle(void)
local_irq_enable();
current_thread_info()->status |= TS_POLLING;
} else {
local_irq_enable();
/* loop is done by the caller */
cpu_relax();
}
Expand All @@ -142,6 +143,7 @@ EXPORT_SYMBOL(default_idle);
*/
static void poll_idle(void)
{
local_irq_enable();
cpu_relax();
}

Expand Down Expand Up @@ -248,8 +250,11 @@ void mwait_idle_with_hints(unsigned long ax, unsigned long cx)
__monitor((void *)&current_thread_info()->flags, 0, 0);
smp_mb();
if (!need_resched())
__mwait(ax, cx);
}
__sti_mwait(ax, cx);
else
local_irq_enable();
} else
local_irq_enable();
}

/* Default MONITOR/MWAIT with no hints, used for default C1 state */
Expand Down

0 comments on commit 3b22ec7

Please sign in to comment.