---

yaml --- r: 320294 b: refs/heads/master c: 456ea46 h: refs/heads/master v: v3
git-mirror · Jul 6, 2012 · 3b4c213 · 3b4c213
1 parent 15fcfb6
commit 3b4c213
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: d65c9e0b9eb43d14ece9dd843506ccba06162ee7
+refs/heads/master: 456ea46865787283088b23a8a7f69244513b95f0
diff --git a/trunk/net/ceph/messenger.c b/trunk/net/ceph/messenger.c
@@ -392,10 +392,16 @@ static int con_close_socket(struct ceph_connection *con)
 	dout("con_close_socket on %p sock %p\n", con, con->sock);
 	if (!con->sock)
 		return 0;
-	set_bit(SOCK_CLOSED, &con->flags);
 	rc = con->sock->ops->shutdown(con->sock, SHUT_RDWR);
 	sock_release(con->sock);
 	con->sock = NULL;
+
+	/*
+	 * Forcibly clear the SOCK_CLOSE flag.  It gets set
+	 * independent of the connection mutex, and we could have
+	 * received a socket close event before we had the chance to
+	 * shut the socket down.
+	 */
 	clear_bit(SOCK_CLOSED, &con->flags);
 	con_sock_state_closed(con);
 	return rc;