Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 125930
b: refs/heads/master
c: 913ae5a
h: refs/heads/master
v: v3
  • Loading branch information
Julia Lawall authored and Takashi Iwai committed Jan 4, 2009
1 parent 9a721a8 commit 3b51c0f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: f4e9749f451747f7cdd334eae951357f839c57f2
refs/heads/master: 913ae5a24efd27deef4fc154953871b62d0d99cd
17 changes: 7 additions & 10 deletions trunk/sound/usb/usbmidi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1392,8 +1392,7 @@ static int snd_usbmidi_get_ms_info(struct snd_usb_midi* umidi,
for (i = 0; i < intfd->bNumEndpoints; ++i) {
hostep = &hostif->endpoint[i];
ep = get_ep_desc(hostep);
if (usb_endpoint_type(ep) != USB_ENDPOINT_XFER_BULK &&
usb_endpoint_type(ep) != USB_ENDPOINT_XFER_INT)
if (!usb_endpoint_xfer_bulk(ep) && !usb_endpoint_xfer_int(ep))
continue;
ms_ep = (struct usb_ms_endpoint_descriptor*)hostep->extra;
if (hostep->extralen < 4 ||
Expand Down Expand Up @@ -1495,8 +1494,8 @@ static int snd_usbmidi_detect_endpoints(struct snd_usb_midi* umidi,

for (i = 0; i < intfd->bNumEndpoints; ++i) {
epd = get_endpoint(hostif, i);
if (usb_endpoint_type(epd) != USB_ENDPOINT_XFER_BULK &&
usb_endpoint_type(epd) != USB_ENDPOINT_XFER_INT)
if (!usb_endpoint_xfer_bulk(epd) &&
!usb_endpoint_xfer_int(epd))
continue;
if (out_eps < max_endpoints &&
usb_endpoint_dir_out(epd)) {
Expand Down Expand Up @@ -1607,21 +1606,19 @@ static int snd_usbmidi_create_endpoints_midiman(struct snd_usb_midi* umidi,
}

epd = get_endpoint(hostif, 0);
if (usb_endpoint_dir_out(epd) ||
usb_endpoint_type(epd) != USB_ENDPOINT_XFER_INT) {
if (!usb_endpoint_dir_in(epd) || !usb_endpoint_xfer_int(epd)) {
snd_printdd(KERN_ERR "endpoint[0] isn't interrupt\n");
return -ENXIO;
}
epd = get_endpoint(hostif, 2);
if (usb_endpoint_dir_in(epd) ||
usb_endpoint_type(epd) != USB_ENDPOINT_XFER_BULK) {
if (!usb_endpoint_dir_out(epd) || !usb_endpoint_xfer_bulk(epd)) {
snd_printdd(KERN_ERR "endpoint[2] isn't bulk output\n");
return -ENXIO;
}
if (endpoint->out_cables > 0x0001) {
epd = get_endpoint(hostif, 4);
if (usb_endpoint_dir_in(epd) ||
usb_endpoint_type(epd) != USB_ENDPOINT_XFER_BULK) {
if (!usb_endpoint_dir_out(epd) ||
!usb_endpoint_xfer_bulk(epd)) {
snd_printdd(KERN_ERR "endpoint[4] isn't bulk output\n");
return -ENXIO;
}
Expand Down
3 changes: 1 addition & 2 deletions trunk/sound/usb/usbmixer.c
Original file line number Diff line number Diff line change
Expand Up @@ -1755,8 +1755,7 @@ static int snd_usb_mixer_status_create(struct usb_mixer_interface *mixer)
if (get_iface_desc(hostif)->bNumEndpoints < 1)
return 0;
ep = get_endpoint(hostif, 0);
if (usb_endpoint_dir_out(ep) ||
usb_endpoint_type(ep) != USB_ENDPOINT_XFER_INT)
if (!usb_endpoint_dir_in(ep) || !usb_endpoint_xfer_int(ep))
return 0;

epnum = usb_endpoint_num(ep);
Expand Down

0 comments on commit 3b51c0f

Please sign in to comment.