Skip to content

Commit

Permalink
staging: sync: Change wait timeout to mirror poll semantics
Browse files Browse the repository at this point in the history
Change wait timeout to act like poll

Cc: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Cc: Erik Gilling <konkers@android.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Rob Clark <robclark@gmail.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: dri-devel@lists.freedesktop.org
Cc: Android Kernel Team <kernel-team@android.com>
Signed-off-by: Erik Gilling <konkers@android.com>
[jstultz: Added commit message, squished typo-fix]
Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Erik Gilling authored and Greg Kroah-Hartman committed Mar 4, 2013
1 parent 03e7a50 commit 3b640f5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions drivers/staging/android/sync.c
Original file line number Diff line number Diff line change
Expand Up @@ -557,14 +557,14 @@ EXPORT_SYMBOL(sync_fence_cancel_async);

int sync_fence_wait(struct sync_fence *fence, long timeout)
{
int err;
int err = 0;

if (timeout) {
if (timeout > 0) {
timeout = msecs_to_jiffies(timeout);
err = wait_event_interruptible_timeout(fence->wq,
fence->status != 0,
timeout);
} else {
} else if (timeout < 0) {
err = wait_event_interruptible(fence->wq, fence->status != 0);
}

Expand Down
8 changes: 4 additions & 4 deletions drivers/staging/android/sync.h
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,8 @@ int sync_fence_cancel_async(struct sync_fence *fence,
* @fence: fence to wait on
* @tiemout: timeout in ms
*
* Wait for @fence to be signaled or have an error. Waits indefintly
* if @timeout = 0
* Wait for @fence to be signaled or have an error. Waits indefinitely
* if @timeout < 0
*/
int sync_fence_wait(struct sync_fence *fence, long timeout);

Expand Down Expand Up @@ -389,9 +389,9 @@ struct sync_fence_info_data {
/**
* DOC: SYNC_IOC_WAIT - wait for a fence to signal
*
* pass timeout in milliseconds.
* pass timeout in milliseconds. Waits indefinitely timeout < 0.
*/
#define SYNC_IOC_WAIT _IOW(SYNC_IOC_MAGIC, 0, __u32)
#define SYNC_IOC_WAIT _IOW(SYNC_IOC_MAGIC, 0, __s32)

/**
* DOC: SYNC_IOC_MERGE - merge two fences
Expand Down

0 comments on commit 3b640f5

Please sign in to comment.