Skip to content

Commit

Permalink
V4L/DVB (3386): Dvb-core: remove dead code
Browse files Browse the repository at this point in the history
The field "dvr" in struct dmxdev is competely unused. Remove
it and code which allocates, initializes and frees it.

Signed-off-by: Peter Beutner <p.beutner@gmx.net>
Signed-off-by: Johannes Stezenbach <js@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Peter Beutner authored and Mauro Carvalho Chehab committed Feb 27, 2006
1 parent 1be11e3 commit 3b81fec
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 27 deletions.
19 changes: 0 additions & 19 deletions drivers/media/dvb/dvb-core/dmxdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,6 @@ static struct dmx_frontend * get_fe(struct dmx_demux *demux, int type)
return NULL;
}

static inline void dvb_dmxdev_dvr_state_set(struct dmxdev_dvr *dmxdevdvr, int state)
{
spin_lock_irq(&dmxdevdvr->dev->lock);
dmxdevdvr->state=state;
spin_unlock_irq(&dmxdevdvr->dev->lock);
}

static int dvb_dvr_open(struct inode *inode, struct file *file)
{
struct dvb_device *dvbdev = file->private_data;
Expand Down Expand Up @@ -1106,22 +1099,12 @@ dvb_dmxdev_init(struct dmxdev *dmxdev, struct dvb_adapter *dvb_adapter)
if (!dmxdev->filter)
return -ENOMEM;

dmxdev->dvr = vmalloc(dmxdev->filternum*sizeof(struct dmxdev_dvr));
if (!dmxdev->dvr) {
vfree(dmxdev->filter);
dmxdev->filter = NULL;
return -ENOMEM;
}

mutex_init(&dmxdev->mutex);
spin_lock_init(&dmxdev->lock);
for (i=0; i<dmxdev->filternum; i++) {
dmxdev->filter[i].dev=dmxdev;
dmxdev->filter[i].buffer.data=NULL;
dvb_dmxdev_filter_state_set(&dmxdev->filter[i], DMXDEV_STATE_FREE);
dmxdev->dvr[i].dev=dmxdev;
dmxdev->dvr[i].buffer.data=NULL;
dvb_dmxdev_dvr_state_set(&dmxdev->dvr[i], DMXDEV_STATE_FREE);
}

dvb_register_device(dvb_adapter, &dmxdev->dvbdev, &dvbdev_demux, dmxdev, DVB_DEVICE_DEMUX);
Expand All @@ -1141,8 +1124,6 @@ dvb_dmxdev_release(struct dmxdev *dmxdev)

vfree(dmxdev->filter);
dmxdev->filter=NULL;
vfree(dmxdev->dvr);
dmxdev->dvr=NULL;
dmxdev->demux->close(dmxdev->demux);
}
EXPORT_SYMBOL(dvb_dmxdev_release);
8 changes: 0 additions & 8 deletions drivers/media/dvb/dvb-core/dmxdev.h
Original file line number Diff line number Diff line change
Expand Up @@ -94,19 +94,11 @@ struct dmxdev_filter {
};


struct dmxdev_dvr {
int state;
struct dmxdev *dev;
struct dmxdev_buffer buffer;
};


struct dmxdev {
struct dvb_device *dvbdev;
struct dvb_device *dvr_dvbdev;

struct dmxdev_filter *filter;
struct dmxdev_dvr *dvr;
struct dmx_demux *demux;

int filternum;
Expand Down

0 comments on commit 3b81fec

Please sign in to comment.