Skip to content

Commit

Permalink
ACPI: PCI: remove unnecessary null pointer checks
Browse files Browse the repository at this point in the history
Better to oops and learn about a bug than to silently cover it up.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Bjorn Helgaas authored and Len Brown committed Dec 31, 2008
1 parent 21a5328 commit 3b8249d
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions drivers/acpi/pci_irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,6 @@ acpi_pci_irq_add_entry(acpi_handle handle,
{
struct acpi_prt_entry *entry = NULL;


if (!prt)
return -EINVAL;

entry = kzalloc(sizeof(struct acpi_prt_entry), GFP_KERNEL);
if (!entry)
return -ENOMEM;
Expand Down Expand Up @@ -432,9 +428,6 @@ acpi_pci_irq_derive(struct pci_dev *dev,
u8 bridge_pin = 0, orig_pin = pin;


if (!dev)
return -EINVAL;

/*
* Attempt to derive an IRQ for this device from a parent bridge's
* PCI interrupt routing entry (eg. yenta bridge and add-in card bridge).
Expand Down Expand Up @@ -491,9 +484,6 @@ int acpi_pci_irq_enable(struct pci_dev *dev)
int rc;


if (!dev)
return -EINVAL;

pin = dev->pin;
if (!pin) {
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
Expand All @@ -503,11 +493,6 @@ int acpi_pci_irq_enable(struct pci_dev *dev)
}
pin--;

if (!dev->bus) {
dev_err(&dev->dev, "invalid (NULL) 'bus' field\n");
return -ENODEV;
}

/*
* First we check the PCI IRQ routing table (PRT) for an IRQ. PRT
* values override any BIOS-assigned IRQs set during boot.
Expand Down Expand Up @@ -586,9 +571,6 @@ void acpi_pci_irq_disable(struct pci_dev *dev)
int polarity = ACPI_ACTIVE_LOW;


if (!dev || !dev->bus)
return;

pin = dev->pin;
if (!pin)
return;
Expand Down

0 comments on commit 3b8249d

Please sign in to comment.