Skip to content

Commit

Permalink
PCI: hotplug/shpchp_hpc: add parenthesis in SLOT_REG_RSVDZ_MASK
Browse files Browse the repository at this point in the history
The SLOT_REG_RSVDZ_MASK macro is normally used like this:
	slot_reg &= ~SLOT_REG_RSVDZ_MASK;
The ~ operator has higher precedence than the | operator from inside the
macro, so it needs parenthesis.

Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Dan Carpenter authored and Jesse Barnes committed Jul 30, 2010
1 parent f673559 commit 3b8fdb7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/pci/hotplug/shpchp_hpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
#define CON_PFAULT_INTR_MASK (1 << 28)
#define MRL_CHANGE_SERR_MASK (1 << 29)
#define CON_PFAULT_SERR_MASK (1 << 30)
#define SLOT_REG_RSVDZ_MASK (1 << 15) | (7 << 21)
#define SLOT_REG_RSVDZ_MASK ((1 << 15) | (7 << 21))

/*
* SHPC Command Code definitnions
Expand Down

0 comments on commit 3b8fdb7

Please sign in to comment.