Skip to content

Commit

Permalink
drm/tegra: Split DC_CMD_STATE_CONTROL register write
Browse files Browse the repository at this point in the history
The Tegra TRM says that the ACT_REQ and UPDATE fields cannot be
programmed at the same time so they are updated in two consecutive
writes instead.

Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
  • Loading branch information
Thierry Reding committed Feb 22, 2013
1 parent 3c03c46 commit 3b9e71e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/gpu/drm/tegra/dc.c
Original file line number Diff line number Diff line change
Expand Up @@ -689,9 +689,10 @@ static void tegra_crtc_commit(struct drm_crtc *crtc)
struct tegra_dc *dc = to_tegra_dc(crtc);
unsigned long value;

value = GENERAL_ACT_REQ | WIN_A_ACT_REQ |
GENERAL_UPDATE | WIN_A_UPDATE;
value = GENERAL_UPDATE | WIN_A_UPDATE;
tegra_dc_writel(dc, value, DC_CMD_STATE_CONTROL);

value = GENERAL_ACT_REQ | WIN_A_ACT_REQ;
tegra_dc_writel(dc, value, DC_CMD_STATE_CONTROL);

drm_vblank_post_modeset(crtc->dev, dc->pipe);
Expand Down

0 comments on commit 3b9e71e

Please sign in to comment.