Skip to content

Commit

Permalink
[media] af9033: implement i/o optimized reg table writer
Browse files Browse the repository at this point in the history
Use register address auto increment to reduce I/O when large
register / values tables are written.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Antti Palosaari authored and Mauro Carvalho Chehab committed Mar 21, 2013
1 parent 0c13c54 commit 3bf5e55
Showing 1 changed file with 37 additions and 10 deletions.
47 changes: 37 additions & 10 deletions drivers/media/dvb-frontends/af9033.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,37 @@ static int af9033_rd_reg_mask(struct af9033_state *state, u32 reg, u8 *val,
return 0;
}

/* write reg val table using reg addr auto increment */
static int af9033_wr_reg_val_tab(struct af9033_state *state,
const struct reg_val *tab, int tab_len)
{
int ret, i, j;
u8 buf[tab_len];

dev_dbg(&state->i2c->dev, "%s: tab_len=%d\n", __func__, tab_len);

for (i = 0, j = 0; i < tab_len; i++) {
buf[j] = tab[i].val;

if (i == tab_len - 1 || tab[i].reg != tab[i + 1].reg - 1) {
ret = af9033_wr_regs(state, tab[i].reg - j, buf, j + 1);
if (ret < 0)
goto err;

j = 0;
} else {
j++;
}
}

return 0;

err:
dev_dbg(&state->i2c->dev, "%s: failed=%d\n", __func__, ret);

return ret;
}

static u32 af9033_div(struct af9033_state *state, u32 a, u32 b, u32 x)
{
u32 r = 0, c = 0, i;
Expand Down Expand Up @@ -306,11 +337,9 @@ static int af9033_init(struct dvb_frontend *fe)
break;
}

for (i = 0; i < len; i++) {
ret = af9033_wr_reg(state, init[i].reg, init[i].val);
if (ret < 0)
goto err;
}
ret = af9033_wr_reg_val_tab(state, init, len);
if (ret < 0)
goto err;

/* load tuner specific settings */
dev_dbg(&state->i2c->dev, "%s: load tuner specific settings\n",
Expand Down Expand Up @@ -371,11 +400,9 @@ static int af9033_init(struct dvb_frontend *fe)
goto err;
}

for (i = 0; i < len; i++) {
ret = af9033_wr_reg(state, init[i].reg, init[i].val);
if (ret < 0)
goto err;
}
ret = af9033_wr_reg_val_tab(state, init, len);
if (ret < 0)
goto err;

if (state->cfg.ts_mode == AF9033_TS_MODE_SERIAL) {
ret = af9033_wr_reg_mask(state, 0x00d91c, 0x01, 0x01);
Expand Down

0 comments on commit 3bf5e55

Please sign in to comment.