Skip to content

Commit

Permalink
ACPI: Separate disabling of GPEs from _PTS
Browse files Browse the repository at this point in the history
The preparation to enter an ACPI system sleep state is now tied to
the disabling of GPEs, but the GPEs should not be disabled before
suspending devices.  Since on ACPI 1.0x systems the _PTS global
control method should be executed before suspending devices, we
need to disable GPEs separately.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Rafael J. Wysocki authored and Len Brown committed Feb 1, 2008
1 parent c95d47a commit 3c1d2b6
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
4 changes: 0 additions & 4 deletions drivers/acpi/hardware/hwsleep.c
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,6 @@ acpi_status acpi_enter_sleep_state_prep(u8 sleep_state)
"While executing method _SST"));
}

/* Disable/Clear all GPEs */

status = acpi_hw_disable_all_gpes();

return_ACPI_STATUS(status);
}

Expand Down
17 changes: 15 additions & 2 deletions drivers/acpi/sleep/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,13 @@ static int acpi_pm_begin(suspend_state_t pm_state)

static int acpi_pm_prepare(void)
{
int error = acpi_sleep_prepare(acpi_target_sleep_state);
int error;

error = acpi_sleep_prepare(acpi_target_sleep_state);
if (error)
acpi_target_sleep_state = ACPI_STATE_S0;
else if (!ACPI_SUCCESS(acpi_hw_disable_all_gpes()))
error = -EFAULT;

return error;
}
Expand Down Expand Up @@ -261,7 +264,16 @@ static int acpi_hibernation_start(void)

static int acpi_hibernation_prepare(void)
{
return acpi_sleep_prepare(ACPI_STATE_S4);
int error;

error = acpi_sleep_prepare(ACPI_STATE_S4);
if (error)
return error;

if (!ACPI_SUCCESS(acpi_hw_disable_all_gpes()))
error = -EFAULT;

return error;
}

static int acpi_hibernation_enter(void)
Expand Down Expand Up @@ -426,6 +438,7 @@ static void acpi_power_off_prepare(void)
{
/* Prepare to power off the system */
acpi_sleep_prepare(ACPI_STATE_S5);
acpi_hw_disable_all_gpes();
}

static void acpi_power_off(void)
Expand Down

0 comments on commit 3c1d2b6

Please sign in to comment.