Skip to content

Commit

Permalink
gigaset: Kconfig cleanup
Browse files Browse the repository at this point in the history
Streamline dependencies and remove some obsolete or redundant comments
in the Gigaset ISDN driver's Kconfig file. In particular, remove the
strong warning against the GIGASET_UNDOCREQ option, as in seven years
of existence, the code in question has never been reported to cause
any harm.

Impact: Kconfig cleanup, no functional change

Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Tilman Schmidt authored and David S. Miller committed Mar 10, 2009
1 parent 1e2d005 commit 3c420f2
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions drivers/isdn/gigaset/Kconfig
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
menuconfig ISDN_DRV_GIGASET
tristate "Siemens Gigaset support (isdn)"
tristate "Siemens Gigaset support"
select CRC_CCITT
select BITREVERSE
help
Expand All @@ -11,27 +11,26 @@ menuconfig ISDN_DRV_GIGASET
one of the connection specific parts that follow.
This will build a module called "gigaset".

if ISDN_DRV_GIGASET!=n
if ISDN_DRV_GIGASET

config GIGASET_BASE
tristate "Gigaset base station support"
depends on ISDN_DRV_GIGASET && USB
depends on USB
help
Say M here if you want to use the USB interface of the Gigaset
base for connection to your system.
This will build a module called "bas_gigaset".

config GIGASET_M105
tristate "Gigaset M105 support"
depends on ISDN_DRV_GIGASET && USB
depends on USB
help
Say M here if you want to connect to the Gigaset base via DECT
using a Gigaset M105 (Sinus 45 Data 2) USB DECT device.
This will build a module called "usb_gigaset".

config GIGASET_M101
tristate "Gigaset M101 support"
depends on ISDN_DRV_GIGASET
help
Say M here if you want to connect to the Gigaset base via DECT
using a Gigaset M101 (Sinus 45 Data 1) RS232 DECT device.
Expand All @@ -48,7 +47,6 @@ config GIGASET_UNDOCREQ
help
This enables support for USB requests we only know from
reverse engineering (currently M105 only). If you need
features like configuration mode of M105, say yes. If you
care about your device, say no.
features like configuration mode of M105, say yes.

endif # ISDN_DRV_GIGASET != n
endif # ISDN_DRV_GIGASET

0 comments on commit 3c420f2

Please sign in to comment.