Skip to content

Commit

Permalink
um: don't rely on sc.fpstate not having been reassigned prior to rt_s…
Browse files Browse the repository at this point in the history
…igreturn()

native rt_sigreturn() doesn't...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Richard Weinberger <richard@nod.at>
  • Loading branch information
Al Viro authored and Richard Weinberger committed Nov 2, 2011
1 parent 78722a4 commit 3c916fe
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions arch/um/sys-x86_64/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ void copy_sc(struct uml_pt_regs *regs, void *from)
}

static int copy_sc_from_user(struct pt_regs *regs,
struct sigcontext __user *from,
struct _fpstate __user *fpp)
struct sigcontext __user *from)
{
struct user_i387_struct fp;
void __user *buf;
int err = 0;

#define GETREG(regs, regno, sc, regname) \
Expand Down Expand Up @@ -78,7 +78,11 @@ static int copy_sc_from_user(struct pt_regs *regs,

#undef GETREG

err = copy_from_user(&fp, fpp, sizeof(struct user_i387_struct));
err = __get_user(buf, &from->fpstate);
if (err)
return 1;

err = copy_from_user(&fp, buf, sizeof(struct user_i387_struct));
if (err)
return 1;

Expand Down Expand Up @@ -272,8 +276,7 @@ long sys_rt_sigreturn(struct pt_regs *regs)
sigdelsetmask(&set, ~_BLOCKABLE);
set_current_blocked(&set);

if (copy_sc_from_user(&current->thread.regs, &uc->uc_mcontext,
&frame->fpstate))
if (copy_sc_from_user(&current->thread.regs, &uc->uc_mcontext))
goto segfault;

/* Avoid ERESTART handling */
Expand Down

0 comments on commit 3c916fe

Please sign in to comment.