Skip to content

Commit

Permalink
tracing: wrap arguments with PARAMS
Browse files Browse the repository at this point in the history
Peter Zijlstra warned that TPPROTO and TPARGS might become something
other than a simple copy of itself. To prevent this from having
side effects in the TRACE_FORMAT macro in tracepoint.h, we add a
PARAMS() macro to be defined as just a wrapper.

Reported-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
  • Loading branch information
Steven Rostedt committed Feb 26, 2009
1 parent eef62a6 commit 3cdfdf9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion include/linux/tracepoint.h
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ static inline void tracepoint_synchronize_unregister(void)
synchronize_sched();
}

#define PARAMS(args...) args
#define TRACE_FORMAT(name, proto, args, fmt) \
DECLARE_TRACE(name, TPPROTO(proto), TPARGS(args))
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))

#endif

0 comments on commit 3cdfdf9

Please sign in to comment.