Skip to content

Commit

Permalink
of_serial: remove driver_data direct access of struct device
Browse files Browse the repository at this point in the history
In the near future, the driver core is going to not allow direct access
to the driver_data pointer in struct device.  Instead, the functions
dev_get_drvdata() and dev_set_drvdata() should be used.  These functions
have been around since the beginning, so are backwards compatible with
all older kernel versions.

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Matthias Fuchs <mfuchs@ma-fu.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Jun 16, 2009
1 parent d779206 commit 3cf62a5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/serial/of_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ static int __devinit of_platform_serial_probe(struct of_device *ofdev,

info->type = port_type;
info->line = ret;
ofdev->dev.driver_data = info;
dev_set_drvdata(&ofdev->dev, info);
return 0;
out:
kfree(info);
Expand All @@ -135,7 +135,7 @@ static int __devinit of_platform_serial_probe(struct of_device *ofdev,
*/
static int of_platform_serial_remove(struct of_device *ofdev)
{
struct of_serial_info *info = ofdev->dev.driver_data;
struct of_serial_info *info = dev_get_drvdata(&ofdev->dev);
switch (info->type) {
#ifdef CONFIG_SERIAL_8250
case PORT_8250 ... PORT_MAX_8250:
Expand Down

0 comments on commit 3cf62a5

Please sign in to comment.