Skip to content

Commit

Permalink
staging: comedi: addi-data: move the main #include's to the drivers
Browse files Browse the repository at this point in the history
The addi-data drivers are all built by the main driver files including
addi-data/addi_common.c. That file then includes other files depending
on what driver is being compiled. This is makes the code quite messy
and hard to follow.

Start cleaning it up by removing the unneeded #include's in addi_common.c
and moving the some of the comedi #include's into the individual driver
files.

This is the first step in getting rid of the #ifdef'ery in addi_common.c.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Oct 30, 2012
1 parent 3974c5c commit 3d41c44
Show file tree
Hide file tree
Showing 17 changed files with 102 additions and 22 deletions.
22 changes: 0 additions & 22 deletions drivers/staging/comedi/drivers/addi-data/addi_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,28 +46,6 @@ You should also find the complete GPL in the COPYING file accompanying this sour
+----------+-----------+------------------------------------------------+
*/

#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/sched.h>
#include <linux/mm.h>
#include <linux/errno.h>
#include <linux/ioport.h>
#include <linux/delay.h>
#include <linux/interrupt.h>
#include <linux/timex.h>
#include <linux/timer.h>
#include <linux/pci.h>
#include <linux/gfp.h>
#include <linux/io.h>
#include "../../comedidev.h"
#if defined(CONFIG_APCI_1710) || defined(CONFIG_APCI_3200) || defined(CONFIG_APCI_3300)
#include <asm/i387.h>
#endif
#include "../comedi_fc.h"

#include "addi_common.h"
#include "addi_amcc_s5933.h"

#ifndef ADDIDATA_DRIVER_NAME
#define ADDIDATA_DRIVER_NAME "addi_common"
#endif
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_035.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_035 1

#define ADDIDATA_WATCHDOG 2 /* Or shold it be something else */
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_1032.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_1032 1

#define ADDIDATA_DRIVER_NAME "addi_apci_1032"
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_1500.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_1500 1

#define ADDIDATA_DRIVER_NAME "addi_apci_1500"
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_1516.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_1516 1

#define ADDIDATA_DRIVER_NAME "addi_apci_1516"
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_1564.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_1564 1

#define ADDIDATA_DRIVER_NAME "addi_apci_1564"
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_16xx.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_16XX 1

#define ADDIDATA_DRIVER_NAME "addi_apci_16xx"
Expand Down
8 changes: 8 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_1710.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
#include <asm/i387.h>

#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_1710 1

#define ADDIDATA_DRIVER_NAME "addi_apci_1710"
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_2016.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_2016 1

#define ADDIDATA_DRIVER_NAME "addi_apci_2016"
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_2032.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_2032 1

#define ADDIDATA_DRIVER_NAME "addi_apci_2032"
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_2200.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_2200 1

#define ADDIDATA_DRIVER_NAME "addi_apci_2200"
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_3001.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_3001 1

#define ADDIDATA_DRIVER_NAME "addi_apci_3001"
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_3120.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_3120 1

#define ADDIDATA_DRIVER_NAME "addi_apci_3120"
Expand Down
8 changes: 8 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_3200.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
#include <asm/i387.h>

#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_3200 1

#define ADDIDATA_DRIVER_NAME "addi_apci_3200"
Expand Down
8 changes: 8 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_3300.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
#include <asm/i387.h>

#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_3300 1

#define ADDIDATA_DRIVER_NAME "addi_apci_3300"
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_3501.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_3501 1

#define ADDIDATA_DRIVER_NAME "addi_apci_3501"
Expand Down
6 changes: 6 additions & 0 deletions drivers/staging/comedi/drivers/addi_apci_3xxx.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#include "../comedidev.h"
#include "comedi_fc.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_3XXX 1

#define ADDIDATA_DRIVER_NAME "addi_apci_3xxx"
Expand Down

0 comments on commit 3d41c44

Please sign in to comment.