Skip to content

Commit

Permalink
x86, smp: remove ->restore_NMI_vector()
Browse files Browse the repository at this point in the history
Nothing actually restores the NMI vector - so remove this
logic altogether.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Jan 28, 2009
1 parent 7bd06ec commit 3d5f597
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 21 deletions.
1 change: 0 additions & 1 deletion arch/x86/include/asm/genapic.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ struct genapic {
void (*wait_for_init_deassert)(atomic_t *deassert);
void (*smp_callin_clear_local_apic)(void);
void (*store_NMI_vector)(unsigned short *high, unsigned short *low);
void (*restore_NMI_vector)(unsigned short *high, unsigned short *low);
void (*inquire_remote_apic)(int apicid);
};

Expand Down
10 changes: 0 additions & 10 deletions arch/x86/include/asm/numaq/wakecpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,6 @@ numaq_store_NMI_vector(unsigned short *high, unsigned short *low)
*((volatile unsigned short *)phys_to_virt(NUMAQ_TRAMPOLINE_PHYS_LOW));
}

static inline void
numaq_restore_NMI_vector(unsigned short *high, unsigned short *low)
{
printk("Restoring NMI vector\n");
*((volatile unsigned short *)phys_to_virt(NUMAQ_TRAMPOLINE_PHYS_HIGH)) =
*high;
*((volatile unsigned short *)phys_to_virt(NUMAQ_TRAMPOLINE_PHYS_LOW)) =
*low;
}

static inline void inquire_remote_apic(int apicid)
{
}
Expand Down
2 changes: 0 additions & 2 deletions arch/x86/kernel/genapic_flat_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ struct genapic apic_flat = {
.wait_for_init_deassert = NULL,
.smp_callin_clear_local_apic = NULL,
.store_NMI_vector = NULL,
.restore_NMI_vector = NULL,
.inquire_remote_apic = NULL,
};

Expand Down Expand Up @@ -375,6 +374,5 @@ struct genapic apic_physflat = {
.wait_for_init_deassert = NULL,
.smp_callin_clear_local_apic = NULL,
.store_NMI_vector = NULL,
.restore_NMI_vector = NULL,
.inquire_remote_apic = NULL,
};
1 change: 0 additions & 1 deletion arch/x86/kernel/genx2apic_cluster.c
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,5 @@ struct genapic apic_x2apic_cluster = {
.wait_for_init_deassert = NULL,
.smp_callin_clear_local_apic = NULL,
.store_NMI_vector = NULL,
.restore_NMI_vector = NULL,
.inquire_remote_apic = NULL,
};
1 change: 0 additions & 1 deletion arch/x86/kernel/genx2apic_phys.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,5 @@ struct genapic apic_x2apic_phys = {
.wait_for_init_deassert = NULL,
.smp_callin_clear_local_apic = NULL,
.store_NMI_vector = NULL,
.restore_NMI_vector = NULL,
.inquire_remote_apic = NULL,
};
1 change: 0 additions & 1 deletion arch/x86/kernel/genx2apic_uv_x.c
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ struct genapic apic_x2apic_uv_x = {
.wait_for_init_deassert = NULL,
.smp_callin_clear_local_apic = NULL,
.store_NMI_vector = NULL,
.restore_NMI_vector = NULL,
.inquire_remote_apic = NULL,
};

Expand Down
1 change: 0 additions & 1 deletion arch/x86/mach-generic/bigsmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,5 @@ struct genapic apic_bigsmp = {

.smp_callin_clear_local_apic = NULL,
.store_NMI_vector = NULL,
.restore_NMI_vector = NULL,
.inquire_remote_apic = inquire_remote_apic,
};
1 change: 0 additions & 1 deletion arch/x86/mach-generic/default.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,5 @@ struct genapic apic_default = {

.smp_callin_clear_local_apic = NULL,
.store_NMI_vector = NULL,
.restore_NMI_vector = NULL,
.inquire_remote_apic = inquire_remote_apic,
};
1 change: 0 additions & 1 deletion arch/x86/mach-generic/es7000.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,5 @@ struct genapic apic_es7000 = {
/* Nothing to do for most platforms, since cleared by the INIT cycle: */
.smp_callin_clear_local_apic = NULL,
.store_NMI_vector = NULL,
.restore_NMI_vector = NULL,
.inquire_remote_apic = inquire_remote_apic,
};
1 change: 0 additions & 1 deletion arch/x86/mach-generic/numaq.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,5 @@ struct genapic apic_numaq = {

.smp_callin_clear_local_apic = numaq_smp_callin_clear_local_apic,
.store_NMI_vector = numaq_store_NMI_vector,
.restore_NMI_vector = numaq_restore_NMI_vector,
.inquire_remote_apic = inquire_remote_apic,
};
1 change: 0 additions & 1 deletion arch/x86/mach-generic/summit.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,5 @@ struct genapic apic_summit = {

.smp_callin_clear_local_apic = NULL,
.store_NMI_vector = NULL,
.restore_NMI_vector = NULL,
.inquire_remote_apic = inquire_remote_apic,
};

0 comments on commit 3d5f597

Please sign in to comment.