Skip to content

Commit

Permalink
metag: protect more non-MMU memory regions
Browse files Browse the repository at this point in the history
Rename setup_txprivext() to setup_priv() and add initialisation of some
more per-thread privilege protection registers:

 - TxPRIVSYSR: 0x04400000-0x047fffff
               0x05000000-0x07ffffff
               0x84000000-0x87ffffff
 - TxPIOREG:   0x02000000-0x02ffffff
               0x04800000-0x048fffff
 - TxSYREG:    0x04000000-0x04000fff (except write fetch system event)

Signed-off-by: James Hogan <james.hogan@imgtec.com>
  • Loading branch information
James Hogan committed Mar 2, 2013
1 parent c787c2d commit 3d6b7bb
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 7 deletions.
2 changes: 1 addition & 1 deletion arch/metag/include/asm/processor.h
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ unsigned long get_wchan(struct task_struct *p);

#define cpu_relax() barrier()

extern void setup_txprivext(void);
extern void setup_priv(void);

static inline unsigned int hard_processor_id(void)
{
Expand Down
45 changes: 40 additions & 5 deletions arch/metag/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include <asm/hwthread.h>
#include <asm/l2cache.h>
#include <asm/mach/arch.h>
#include <asm/metag_mem.h>
#include <asm/metag_regs.h>
#include <asm/mmu.h>
#include <asm/mmzone.h>
Expand Down Expand Up @@ -75,6 +76,32 @@
META2_PRIV | \
UNALIGNED_PRIV)

/*
* Protect access to:
* 0x06000000-0x07ffffff Direct mapped region
* 0x05000000-0x05ffffff MMU table region (Meta1)
* 0x04400000-0x047fffff Cache flush region
* 0x84000000-0x87ffffff Core cache memory region (Meta2)
*
* Allow access to:
* 0x80000000-0x81ffffff Core code memory region (Meta2)
*/
#ifdef CONFIG_METAG_META12
#define PRIVSYSR_BITS TXPRIVSYSR_ALL_BITS
#else
#define PRIVSYSR_BITS (TXPRIVSYSR_ALL_BITS & ~TXPRIVSYSR_CORECODE_BIT)
#endif

/* Protect all 0x02xxxxxx and 0x048xxxxx. */
#define PIOREG_BITS 0xffffffff

/*
* Protect all 0x04000xx0 (system events)
* except write combiner flush and write fence (system events 4 and 5).
*/
#define PSYREG_BITS 0xfffffffb


extern char _heap_start[];

#ifdef CONFIG_METAG_BUILTIN_DTB
Expand Down Expand Up @@ -371,7 +398,7 @@ void __init setup_arch(char **cmdline_p)

paging_init(heap_end);

setup_txprivext();
setup_priv();

/* Setup the boot cpu's mapping. The rest will be setup below. */
cpu_2_hwthread_id[smp_processor_id()] = hard_processor_id();
Expand Down Expand Up @@ -531,13 +558,21 @@ void __init metag_start_kernel(char *args)
start_kernel();
}

/*
* Setup TXPRIVEXT register to be prevent userland from touching our
* precious registers.
/**
* setup_priv() - Set up privilege protection registers.
*
* Set up privilege protection registers such as TXPRIVEXT to prevent userland
* from touching our precious registers and sensitive memory areas.
*/
void setup_txprivext(void)
void setup_priv(void)
{
unsigned int offset = hard_processor_id() << TXPRIVREG_STRIDE_S;

__core_reg_set(TXPRIVEXT, PRIV_BITS);

metag_out32(PRIVSYSR_BITS, T0PRIVSYSR + offset);
metag_out32(PIOREG_BITS, T0PIOREG + offset);
metag_out32(PSYREG_BITS, T0PSYREG + offset);
}

PTBI pTBI_get(unsigned int cpu)
Expand Down
2 changes: 1 addition & 1 deletion arch/metag/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ asmlinkage void secondary_start_kernel(void)

preempt_disable();

setup_txprivext();
setup_priv();

/*
* Enable local interrupts.
Expand Down

0 comments on commit 3d6b7bb

Please sign in to comment.