Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 158117
b: refs/heads/master
c: f607c66
h: refs/heads/master
i:
  158115: 93923f5
v: v3
  • Loading branch information
Peter Zijlstra authored and Ingo Molnar committed Aug 2, 2009
1 parent 62ac934 commit 3d73946
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 1 deletion.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 98c33eddaf41d225d99b40f9eedbd0fac4c08c05
refs/heads/master: f607c6685774811b8112e124f10a053d77015485
8 changes: 8 additions & 0 deletions trunk/include/linux/lockdep.h
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,10 @@ extern void lock_acquire(struct lockdep_map *lock, unsigned int subclass,
extern void lock_release(struct lockdep_map *lock, int nested,
unsigned long ip);

#define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)

extern int lock_is_held(struct lockdep_map *lock);

extern void lock_set_class(struct lockdep_map *lock, const char *name,
struct lock_class_key *key, unsigned int subclass,
unsigned long ip);
Expand All @@ -314,6 +318,8 @@ extern void lockdep_trace_alloc(gfp_t mask);

#define lockdep_depth(tsk) (debug_locks ? (tsk)->lockdep_depth : 0)

#define lockdep_assert_held(l) WARN_ON(debug_locks && !lockdep_is_held(l))

#else /* !LOCKDEP */

static inline void lockdep_off(void)
Expand Down Expand Up @@ -358,6 +364,8 @@ struct lock_class_key { };

#define lockdep_depth(tsk) (0)

#define lockdep_assert_held(l) do { } while (0)

#endif /* !LOCKDEP */

#ifdef CONFIG_LOCK_STAT
Expand Down
33 changes: 33 additions & 0 deletions trunk/kernel/lockdep.c
Original file line number Diff line number Diff line change
Expand Up @@ -3059,6 +3059,19 @@ __lock_release(struct lockdep_map *lock, int nested, unsigned long ip)
check_chain_key(curr);
}

static int __lock_is_held(struct lockdep_map *lock)
{
struct task_struct *curr = current;
int i;

for (i = 0; i < curr->lockdep_depth; i++) {
if (curr->held_locks[i].instance == lock)
return 1;
}

return 0;
}

/*
* Check whether we follow the irq-flags state precisely:
*/
Expand Down Expand Up @@ -3160,6 +3173,26 @@ void lock_release(struct lockdep_map *lock, int nested,
}
EXPORT_SYMBOL_GPL(lock_release);

int lock_is_held(struct lockdep_map *lock)
{
unsigned long flags;
int ret = 0;

if (unlikely(current->lockdep_recursion))
return ret;

raw_local_irq_save(flags);
check_flags(flags);

current->lockdep_recursion = 1;
ret = __lock_is_held(lock);
current->lockdep_recursion = 0;
raw_local_irq_restore(flags);

return ret;
}
EXPORT_SYMBOL_GPL(lock_is_held);

void lockdep_set_current_reclaim_state(gfp_t gfp_mask)
{
current->lockdep_reclaim_gfp = gfp_mask;
Expand Down
2 changes: 2 additions & 0 deletions trunk/kernel/sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -6609,6 +6609,8 @@ int cond_resched_lock(spinlock_t *lock)
int resched = should_resched();
int ret = 0;

lockdep_assert_held(lock);

if (spin_needbreak(lock) || resched) {
spin_unlock(lock);
if (resched)
Expand Down

0 comments on commit 3d73946

Please sign in to comment.