Skip to content

Commit

Permalink
[PATCH] s390: fix arp_tbl lock usage in qeth
Browse files Browse the repository at this point in the history
qeth: bhs must be disabled when accessing neighbour tables.

=================================
[ INFO: inconsistent lock state ]

Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Heiko Carstens authored and Jeff Garzik committed Aug 19, 2006
1 parent 239e44e commit 3d8f3f3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/s390/net/qeth_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -8510,9 +8510,9 @@ static int
qeth_ipv6_init(void)
{
qeth_old_arp_constructor = arp_tbl.constructor;
write_lock(&arp_tbl.lock);
write_lock_bh(&arp_tbl.lock);
arp_tbl.constructor = qeth_arp_constructor;
write_unlock(&arp_tbl.lock);
write_unlock_bh(&arp_tbl.lock);

arp_direct_ops = (struct neigh_ops*)
kmalloc(sizeof(struct neigh_ops), GFP_KERNEL);
Expand All @@ -8528,9 +8528,9 @@ qeth_ipv6_init(void)
static void
qeth_ipv6_uninit(void)
{
write_lock(&arp_tbl.lock);
write_lock_bh(&arp_tbl.lock);
arp_tbl.constructor = qeth_old_arp_constructor;
write_unlock(&arp_tbl.lock);
write_unlock_bh(&arp_tbl.lock);
kfree(arp_direct_ops);
}
#endif /* CONFIG_QETH_IPV6 */
Expand Down

0 comments on commit 3d8f3f3

Please sign in to comment.