Skip to content

Commit

Permalink
OMAPDSS: sharp-ls panel: remove platform_enable/disable callbacks
Browse files Browse the repository at this point in the history
The sharp-ls panel driver now manages the gpios required to configure the panel.
This was previously done in omap_dss_device's platform_enable/disable callbacks
defined in board files using this panel.

All the board files using this panel now pass the gpio information as platform
data via the panel_sharp_ls037v7dw01_data struct, which is needed by the panel
driver to configure the gpios connected to the panel. Hence, the
platform_enable/disable ops can be safely removed now.

Signed-off-by: Archit Taneja <archit@ti.com>
  • Loading branch information
Archit Taneja authored and Tomi Valkeinen committed Apr 3, 2013
1 parent 3103098 commit 3db716b
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,21 +125,13 @@ static int sharp_ls_power_on(struct omap_dss_device *dssdev)
/* wait couple of vsyncs until enabling the LCD */
msleep(50);

if (dssdev->platform_enable) {
r = dssdev->platform_enable(dssdev);
if (r)
goto err1;
}

if (gpio_is_valid(pd->resb_gpio))
gpio_set_value_cansleep(pd->resb_gpio, 1);

if (gpio_is_valid(pd->ini_gpio))
gpio_set_value_cansleep(pd->ini_gpio, 1);

return 0;
err1:
omapdss_dpi_display_disable(dssdev);
err0:
return r;
}
Expand All @@ -157,9 +149,6 @@ static void sharp_ls_power_off(struct omap_dss_device *dssdev)
if (gpio_is_valid(pd->resb_gpio))
gpio_set_value_cansleep(pd->resb_gpio, 0);

if (dssdev->platform_disable)
dssdev->platform_disable(dssdev);

/* wait at least 5 vsyncs after disabling the LCD */

msleep(100);
Expand Down

0 comments on commit 3db716b

Please sign in to comment.