Skip to content

Commit

Permalink
qlge: call ql_core_dump() only if dump memory was allocated.
Browse files Browse the repository at this point in the history
Also changed a log message to indicate that memory was not allocated
instead of memory not available!

Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
Acked-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
malahal@us.ibm.com authored and David S. Miller committed Sep 24, 2013
1 parent 3361dc9 commit 3db9180
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/qlogic/qlge/qlge_dbg.c
Original file line number Diff line number Diff line change
Expand Up @@ -740,8 +740,8 @@ int ql_core_dump(struct ql_adapter *qdev, struct ql_mpi_coredump *mpi_coredump)
int i;

if (!mpi_coredump) {
netif_err(qdev, drv, qdev->ndev, "No memory available\n");
return -ENOMEM;
netif_err(qdev, drv, qdev->ndev, "No memory allocated\n");
return -EINVAL;
}

/* Try to get the spinlock, but dont worry if
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ethernet/qlogic/qlge/qlge_mpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1274,7 +1274,7 @@ void ql_mpi_reset_work(struct work_struct *work)
return;
}

if (!ql_core_dump(qdev, qdev->mpi_coredump)) {
if (qdev->mpi_coredump && !ql_core_dump(qdev, qdev->mpi_coredump)) {
netif_err(qdev, drv, qdev->ndev, "Core is dumped!\n");
qdev->core_is_dumped = 1;
queue_delayed_work(qdev->workqueue,
Expand Down

0 comments on commit 3db9180

Please sign in to comment.