Skip to content

Commit

Permalink
Input: ucb1400 - use disable_irq_nosync() in irq handler
Browse files Browse the repository at this point in the history
disable_irq() waits for all running handlers to complete before
returning.  As such, if it's used to disable an interrupt from
that interrupt's handler it will deadlock.  This replaces the
dangerous instances with the _nosync() variant which doesn't have
this problem.

Signed-off-by: Ben Nizette <bn@niasdigital.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Ben Nizette authored and Dmitry Torokhov committed Apr 18, 2009
1 parent 29fa98b commit 3deb649
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/input/touchscreen/ucb1400_ts.c
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ static irqreturn_t ucb1400_hard_irq(int irqnr, void *devid)
struct ucb1400_ts *ucb = devid;

if (irqnr == ucb->irq) {
disable_irq(ucb->irq);
disable_irq_nosync(ucb->irq);
ucb->irq_pending = 1;
wake_up(&ucb->ts_wait);
return IRQ_HANDLED;
Expand Down

0 comments on commit 3deb649

Please sign in to comment.