Skip to content

Commit

Permalink
KVM: Simplify vcpu_enter_guest() mmu reload logic slightly
Browse files Browse the repository at this point in the history
No need to reload the mmu in between two different vcpu->requests checks.

kvm_mmu_reload() may trigger KVM_REQ_TRIPLE_FAULT, but that will be caught
during atomic guest entry later.

Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
  • Loading branch information
Avi Kivity committed Aug 1, 2010
1 parent 529df65 commit 3e00750
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions arch/x86/kvm/x86.c
Original file line number Diff line number Diff line change
Expand Up @@ -4616,15 +4616,9 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
bool req_int_win = !irqchip_in_kernel(vcpu->kvm) &&
vcpu->run->request_interrupt_window;

if (vcpu->requests)
if (vcpu->requests) {
if (kvm_check_request(KVM_REQ_MMU_RELOAD, vcpu))
kvm_mmu_unload(vcpu);

r = kvm_mmu_reload(vcpu);
if (unlikely(r))
goto out;

if (vcpu->requests) {
if (kvm_check_request(KVM_REQ_MIGRATE_TIMER, vcpu))
__kvm_migrate_timers(vcpu);
if (kvm_check_request(KVM_REQ_KVMCLOCK_UPDATE, vcpu))
Expand All @@ -4649,6 +4643,10 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
}
}

r = kvm_mmu_reload(vcpu);
if (unlikely(r))
goto out;

preempt_disable();

kvm_x86_ops->prepare_guest_switch(vcpu);
Expand Down

0 comments on commit 3e00750

Please sign in to comment.