Skip to content

Commit

Permalink
KVM: Simplify kvm_clear_guest_page()
Browse files Browse the repository at this point in the history
Use kvm_write_guest_page() with empty_zero_page, instead of doing
kmap and memset.

Signed-off-by: Izik Eidus <izike@qumranet.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
  • Loading branch information
Izik Eidus authored and Avi Kivity committed Jan 30, 2008
1 parent ec8d4ea commit 3e021bf
Showing 1 changed file with 2 additions and 16 deletions.
18 changes: 2 additions & 16 deletions drivers/kvm/kvm_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
#include <asm/io.h>
#include <asm/uaccess.h>
#include <asm/desc.h>
#include <asm/pgtable.h>

MODULE_AUTHOR("Qumranet");
MODULE_LICENSE("GPL");
Expand Down Expand Up @@ -633,22 +634,7 @@ int kvm_write_guest(struct kvm *kvm, gpa_t gpa, const void *data,

int kvm_clear_guest_page(struct kvm *kvm, gfn_t gfn, int offset, int len)
{
void *page_virt;
struct page *page;

page = gfn_to_page(kvm, gfn);
if (is_error_page(page)) {
kvm_release_page(page);
return -EFAULT;
}
page_virt = kmap_atomic(page, KM_USER0);

memset(page_virt + offset, 0, len);

kunmap_atomic(page_virt, KM_USER0);
kvm_release_page(page);
mark_page_dirty(kvm, gfn);
return 0;
return kvm_write_guest_page(kvm, gfn, empty_zero_page, offset, len);
}
EXPORT_SYMBOL_GPL(kvm_clear_guest_page);

Expand Down

0 comments on commit 3e021bf

Please sign in to comment.