Skip to content

Commit

Permalink
sysfs.h: remove attr_name() macro
Browse files Browse the repository at this point in the history
Gotta love a macro that doesn't reduce the typing you have to do.

Also, only the driver core, and one network driver uses this.  The
driver core functions will be going away soon, and I'll convert the
network driver soon to not need this as well, so delete it for now
before anyone else gets some bright ideas and wants to use it.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed Aug 22, 2013
1 parent 09239ed commit 3e1026b
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 15 deletions.
12 changes: 6 additions & 6 deletions drivers/base/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ static int device_add_attrs(struct bus_type *bus, struct device *dev)
if (!bus->dev_attrs)
return 0;

for (i = 0; attr_name(bus->dev_attrs[i]); i++) {
for (i = 0; bus->dev_attrs[i].attr.name; i++) {
error = device_create_file(dev, &bus->dev_attrs[i]);
if (error) {
while (--i >= 0)
Expand All @@ -476,7 +476,7 @@ static void device_remove_attrs(struct bus_type *bus, struct device *dev)
int i;

if (bus->dev_attrs) {
for (i = 0; attr_name(bus->dev_attrs[i]); i++)
for (i = 0; bus->dev_attrs[i].attr.name; i++)
device_remove_file(dev, &bus->dev_attrs[i]);
}
}
Expand Down Expand Up @@ -596,7 +596,7 @@ static int driver_add_attrs(struct bus_type *bus, struct device_driver *drv)
int i;

if (bus->drv_attrs) {
for (i = 0; attr_name(bus->drv_attrs[i]); i++) {
for (i = 0; bus->drv_attrs[i].attr.name; i++) {
error = driver_create_file(drv, &bus->drv_attrs[i]);
if (error)
goto err;
Expand All @@ -616,7 +616,7 @@ static void driver_remove_attrs(struct bus_type *bus,
int i;

if (bus->drv_attrs) {
for (i = 0; attr_name(bus->drv_attrs[i]); i++)
for (i = 0; bus->drv_attrs[i].attr.name; i++)
driver_remove_file(drv, &bus->drv_attrs[i]);
}
}
Expand Down Expand Up @@ -857,7 +857,7 @@ static int bus_add_attrs(struct bus_type *bus)
int i;

if (bus->bus_attrs) {
for (i = 0; attr_name(bus->bus_attrs[i]); i++) {
for (i = 0; bus->bus_attrs[i].attr.name; i++) {
error = bus_create_file(bus, &bus->bus_attrs[i]);
if (error)
goto err;
Expand All @@ -876,7 +876,7 @@ static void bus_remove_attrs(struct bus_type *bus)
int i;

if (bus->bus_attrs) {
for (i = 0; attr_name(bus->bus_attrs[i]); i++)
for (i = 0; bus->bus_attrs[i].attr.name; i++)
bus_remove_file(bus, &bus->bus_attrs[i]);
}
}
Expand Down
4 changes: 2 additions & 2 deletions drivers/base/class.c
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ static int add_class_attrs(struct class *cls)
int error = 0;

if (cls->class_attrs) {
for (i = 0; attr_name(cls->class_attrs[i]); i++) {
for (i = 0; cls->class_attrs[i].attr.name; i++) {
error = class_create_file(cls, &cls->class_attrs[i]);
if (error)
goto error;
Expand All @@ -154,7 +154,7 @@ static void remove_class_attrs(struct class *cls)
int i;

if (cls->class_attrs) {
for (i = 0; attr_name(cls->class_attrs[i]); i++)
for (i = 0; cls->class_attrs[i].attr.name; i++)
class_remove_file(cls, &cls->class_attrs[i]);
}
}
Expand Down
8 changes: 4 additions & 4 deletions drivers/base/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ static int device_add_attributes(struct device *dev,
int i;

if (attrs) {
for (i = 0; attr_name(attrs[i]); i++) {
for (i = 0; attrs[i].attr.name; i++) {
error = device_create_file(dev, &attrs[i]);
if (error)
break;
Expand All @@ -458,7 +458,7 @@ static void device_remove_attributes(struct device *dev,
int i;

if (attrs)
for (i = 0; attr_name(attrs[i]); i++)
for (i = 0; attrs[i].attr.name; i++)
device_remove_file(dev, &attrs[i]);
}

Expand All @@ -469,7 +469,7 @@ static int device_add_bin_attributes(struct device *dev,
int i;

if (attrs) {
for (i = 0; attr_name(attrs[i]); i++) {
for (i = 0; attrs[i].attr.name; i++) {
error = device_create_bin_file(dev, &attrs[i]);
if (error)
break;
Expand All @@ -487,7 +487,7 @@ static void device_remove_bin_attributes(struct device *dev,
int i;

if (attrs)
for (i = 0; attr_name(attrs[i]); i++)
for (i = 0; attrs[i].attr.name; i++)
device_remove_bin_file(dev, &attrs[i]);
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ethernet/sun/niu.c
Original file line number Diff line number Diff line change
Expand Up @@ -9478,7 +9478,7 @@ static struct niu_parent *niu_new_parent(struct niu *np,
if (IS_ERR(plat_dev))
return NULL;

for (i = 0; attr_name(niu_parent_attributes[i]); i++) {
for (i = 0; niu_parent_attributes[i].attr.name; i++) {
int err = device_create_file(&plat_dev->dev,
&niu_parent_attributes[i]);
if (err)
Expand Down
2 changes: 0 additions & 2 deletions include/linux/sysfs.h
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@ static const struct attribute_group _name##_group = { \
}; \
__ATTRIBUTE_GROUPS(_name)

#define attr_name(_attr) (_attr).attr.name

struct file;
struct vm_area_struct;

Expand Down

0 comments on commit 3e1026b

Please sign in to comment.