Skip to content

Commit

Permalink
rt2x00: Fix chipset debugfs file
Browse files Browse the repository at this point in the history
Initialize blob->data before moving the data pointer
Initialize blob->size based on blob->data size

This fixes the empty chipset file in debugfs.

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Ivo van Doorn authored and David S. Miller committed Jan 28, 2008
1 parent 96c755a commit 3e34c6d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/net/wireless/rt2x00/rt2x00debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@ static struct dentry *rt2x00debug_create_file_chipset(const char *name,
if (!data)
return NULL;

blob->data = data;
data += sprintf(data, "rt chip: %04x\n", intf->rt2x00dev->chip.rt);
data += sprintf(data, "rf chip: %04x\n", intf->rt2x00dev->chip.rf);
data += sprintf(data, "revision:%08x\n", intf->rt2x00dev->chip.rev);
Expand All @@ -425,9 +426,7 @@ static struct dentry *rt2x00debug_create_file_chipset(const char *name,
data += sprintf(data, "eeprom length: %d\n", debug->eeprom.word_count);
data += sprintf(data, "bbp length: %d\n", debug->bbp.word_count);
data += sprintf(data, "rf length: %d\n", debug->rf.word_count);

blob->data = data;
blob->size = strlen(data);
blob->size = strlen(blob->data);

return debugfs_create_blob(name, S_IRUGO, intf->driver_folder, blob);
}
Expand Down

0 comments on commit 3e34c6d

Please sign in to comment.