Skip to content

Commit

Permalink
[IPV4]: Use ctl paths to register net/ipv4/ table
Browse files Browse the repository at this point in the history
This is the same as I did for the net/core/ table in the
second patch in his series: use the paths and isolate the
whole table in the .c file.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Pavel Emelyanov authored and David S. Miller committed Jan 28, 2008
1 parent 9ba6397 commit 3e37c3f
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 11 deletions.
2 changes: 0 additions & 2 deletions include/net/ip.h
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,4 @@ int ipv4_doint_and_flush_strategy(ctl_table *table, int __user *name, int nlen,
extern int ip_misc_proc_init(void);
#endif

extern struct ctl_table ipv4_table[];

#endif /* _IP_H */
19 changes: 18 additions & 1 deletion net/ipv4/sysctl_net_ipv4.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include <linux/igmp.h>
#include <linux/inetdevice.h>
#include <linux/seqlock.h>
#include <linux/init.h>
#include <net/snmp.h>
#include <net/icmp.h>
#include <net/ip.h>
Expand Down Expand Up @@ -247,7 +248,7 @@ static int strategy_allowed_congestion_control(ctl_table *table, int __user *nam

}

ctl_table ipv4_table[] = {
static struct ctl_table ipv4_table[] = {
{
.ctl_name = NET_IPV4_TCP_TIMESTAMPS,
.procname = "tcp_timestamps",
Expand Down Expand Up @@ -878,3 +879,19 @@ ctl_table ipv4_table[] = {
},
{ .ctl_name = 0 }
};

static __initdata struct ctl_path net_ipv4_path[] = {
{ .procname = "net", .ctl_name = CTL_NET, },
{ .procname = "ipv4", .ctl_name = NET_IPV4, },
{ },
};

static __init int sysctl_ipv4_init(void)
{
struct ctl_table_header *hdr;

hdr = register_sysctl_paths(net_ipv4_path, ipv4_table);
return hdr == NULL ? -ENOMEM : 0;
}

__initcall(sysctl_ipv4_init);
8 changes: 0 additions & 8 deletions net/sysctl_net.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,6 @@
#endif

struct ctl_table net_table[] = {
#ifdef CONFIG_INET
{
.ctl_name = NET_IPV4,
.procname = "ipv4",
.mode = 0555,
.child = ipv4_table
},
#endif
#ifdef CONFIG_TR
{
.ctl_name = NET_TR,
Expand Down

0 comments on commit 3e37c3f

Please sign in to comment.