Skip to content

Commit

Permalink
sched: Remove unused parameters from sched_fork() and wake_up_new_task()
Browse files Browse the repository at this point in the history
sched_fork() and wake_up_new_task() are defined with a parameter
'unsigned long clone_flags', which is unused.

This patch removes the parameters.

Signed-off-by: Samir Bellabes <sam@synack.fr>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1305130685-1047-1-git-send-email-sam@synack.fr
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Samir Bellabes authored and Ingo Molnar committed May 12, 2011
1 parent 9cb5bab commit 3e51e3e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
5 changes: 2 additions & 3 deletions include/linux/sched.h
Original file line number Diff line number Diff line change
Expand Up @@ -2051,14 +2051,13 @@ extern void xtime_update(unsigned long ticks);

extern int wake_up_state(struct task_struct *tsk, unsigned int state);
extern int wake_up_process(struct task_struct *tsk);
extern void wake_up_new_task(struct task_struct *tsk,
unsigned long clone_flags);
extern void wake_up_new_task(struct task_struct *tsk);
#ifdef CONFIG_SMP
extern void kick_process(struct task_struct *tsk);
#else
static inline void kick_process(struct task_struct *tsk) { }
#endif
extern void sched_fork(struct task_struct *p, int clone_flags);
extern void sched_fork(struct task_struct *p);
extern void sched_dead(struct task_struct *p);

extern void proc_caches_init(void);
Expand Down
4 changes: 2 additions & 2 deletions kernel/fork.c
Original file line number Diff line number Diff line change
Expand Up @@ -1152,7 +1152,7 @@ static struct task_struct *copy_process(unsigned long clone_flags,
#endif

/* Perform scheduler related setup. Assign this task to a CPU. */
sched_fork(p, clone_flags);
sched_fork(p);

retval = perf_event_init_task(p);
if (retval)
Expand Down Expand Up @@ -1463,7 +1463,7 @@ long do_fork(unsigned long clone_flags,
*/
p->flags &= ~PF_STARTING;

wake_up_new_task(p, clone_flags);
wake_up_new_task(p);

tracehook_report_clone_complete(trace, regs,
clone_flags, nr, p);
Expand Down
4 changes: 2 additions & 2 deletions kernel/sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -2741,7 +2741,7 @@ static void __sched_fork(struct task_struct *p)
/*
* fork()/clone()-time setup:
*/
void sched_fork(struct task_struct *p, int clone_flags)
void sched_fork(struct task_struct *p)
{
unsigned long flags;
int cpu = get_cpu();
Expand Down Expand Up @@ -2823,7 +2823,7 @@ void sched_fork(struct task_struct *p, int clone_flags)
* that must be done for every newly created context, then puts the task
* on the runqueue and wakes it.
*/
void wake_up_new_task(struct task_struct *p, unsigned long clone_flags)
void wake_up_new_task(struct task_struct *p)
{
unsigned long flags;
struct rq *rq;
Expand Down

0 comments on commit 3e51e3e

Please sign in to comment.