Skip to content

Commit

Permalink
bnx2x: smp_mb and not just smp_rmb
Browse files Browse the repository at this point in the history
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eilon Greenstein authored and David S. Miller committed Feb 16, 2009
1 parent 8b3a0f0 commit 3e5b510
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/bnx2x_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -7173,7 +7173,7 @@ static int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode)
struct bnx2x_fastpath *fp = &bp->fp[i];

cnt = 1000;
smp_rmb();
smp_mb();
while (bnx2x_has_tx_work_unload(fp)) {

bnx2x_tx_int(fp, 1000);
Expand All @@ -7189,7 +7189,7 @@ static int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode)
}
cnt--;
msleep(1);
smp_rmb();
smp_mb();
}
}
/* Give HW time to discard old tx messages */
Expand Down

0 comments on commit 3e5b510

Please sign in to comment.