Skip to content

Commit

Permalink
pinctrl: sirf: remove unnecessary platform_set_drvdata()
Browse files Browse the repository at this point in the history
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d06
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Jingoo Han authored and Linus Walleij committed Jun 16, 2013
1 parent 59eb14d commit 3e6eeaf
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/pinctrl/pinctrl-sirf.c
Original file line number Diff line number Diff line change
Expand Up @@ -1280,9 +1280,8 @@ static int sirfsoc_pinmux_probe(struct platform_device *pdev)

spmx->gpio_virtbase = of_iomap(np, 0);
if (!spmx->gpio_virtbase) {
ret = -ENOMEM;
dev_err(&pdev->dev, "can't map gpio registers\n");
goto out_no_gpio_remap;
return -ENOMEM;
}

spmx->rsc_virtbase = sirfsoc_rsc_of_iomap();
Expand Down Expand Up @@ -1316,8 +1315,6 @@ static int sirfsoc_pinmux_probe(struct platform_device *pdev)
iounmap(spmx->rsc_virtbase);
out_no_rsc_remap:
iounmap(spmx->gpio_virtbase);
out_no_gpio_remap:
platform_set_drvdata(pdev, NULL);
return ret;
}

Expand Down

0 comments on commit 3e6eeaf

Please sign in to comment.