Skip to content

Commit

Permalink
[CPUFREQ] sc520_freq.c: ioremap balanced with iounmap
Browse files Browse the repository at this point in the history
ioremap must be balanced by an iounmap and failing to do so can result
in a memory leak.

Tested (compilation only):
- using allmodconfig
- making sure the files are compiling without any warning/error due to
new changes

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Signed-off-by: Dave Jones <davej@redhat.com>
  • Loading branch information
Amol Lad authored and Dave Jones committed Oct 18, 2006
1 parent dfde5d6 commit 3e74341
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion arch/i386/kernel/cpu/cpufreq/sc520_freq.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ static struct cpufreq_driver sc520_freq_driver = {
static int __init sc520_freq_init(void)
{
struct cpuinfo_x86 *c = cpu_data;
int err;

/* Test if we have the right hardware */
if(c->x86_vendor != X86_VENDOR_AMD ||
Expand All @@ -166,7 +167,11 @@ static int __init sc520_freq_init(void)
return -ENOMEM;
}

return cpufreq_register_driver(&sc520_freq_driver);
err = cpufreq_register_driver(&sc520_freq_driver);
if (err)
iounmap(cpuctl);

return err;
}


Expand Down

0 comments on commit 3e74341

Please sign in to comment.