Skip to content

Commit

Permalink
[SCSI] qla2xxx: Correctly set the firmware NOS/OLS timeout during ini…
Browse files Browse the repository at this point in the history
…tialization.

Original code incorrectly assigned it to the driver's
link-down-timeout value (a value in seconds).

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
Andrew Vasquez authored and James Bottomley committed Jun 26, 2006
1 parent 7ee6139 commit 3ea66e2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion drivers/scsi/qla2xxx/qla_fw.h
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ struct init_cb_24xx {
uint16_t response_q_length;
uint16_t request_q_length;

uint16_t link_down_timeout; /* Milliseconds. */
uint16_t link_down_on_nos; /* Milliseconds. */

uint16_t prio_request_q_length;

Expand Down
3 changes: 1 addition & 2 deletions drivers/scsi/qla2xxx/qla_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -3379,7 +3379,6 @@ qla24xx_nvram_config(scsi_qla_host_t *ha)
nv->node_name[6] = 0x55;
nv->node_name[7] = 0x86;
nv->login_retry_count = __constant_cpu_to_le16(8);
nv->link_down_timeout = __constant_cpu_to_le16(200);
nv->interrupt_delay_timer = __constant_cpu_to_le16(0);
nv->login_timeout = __constant_cpu_to_le16(0);
nv->firmware_options_1 =
Expand Down Expand Up @@ -3408,7 +3407,7 @@ qla24xx_nvram_config(scsi_qla_host_t *ha)
*dptr1++ = *dptr2++;

icb->login_retry_count = nv->login_retry_count;
icb->link_down_timeout = nv->link_down_timeout;
icb->link_down_on_nos = nv->link_down_on_nos;

/* Copy 2nd segment. */
dptr1 = (uint8_t *)&icb->interrupt_delay_timer;
Expand Down

0 comments on commit 3ea66e2

Please sign in to comment.