Skip to content

Commit

Permalink
[NET]: drop duplicate assignment in request_sock
Browse files Browse the repository at this point in the history
Just noticed that request_sock.[ch] contain a useless assignment of
rskq_accept_head to itself.  I assume this is a typo and the 2nd one
was supposed to be _tail.  However, setting _tail to NULL is not
needed, so the patch below just drops the 2nd assignment.

Signed-off-By: Norbert Kiesel <nkiesel@tbdnetworks.com>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Norbert Kiesel authored and David S. Miller committed Mar 27, 2006
1 parent 6abaaaa commit 3eb4801
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion include/net/request_sock.h
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ static inline struct request_sock *
{
struct request_sock *req = queue->rskq_accept_head;

queue->rskq_accept_head = queue->rskq_accept_head = NULL;
queue->rskq_accept_head = NULL;
return req;
}

Expand Down
2 changes: 1 addition & 1 deletion net/core/request_sock.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ int reqsk_queue_alloc(struct request_sock_queue *queue,

get_random_bytes(&lopt->hash_rnd, sizeof(lopt->hash_rnd));
rwlock_init(&queue->syn_wait_lock);
queue->rskq_accept_head = queue->rskq_accept_head = NULL;
queue->rskq_accept_head = NULL;
lopt->nr_table_entries = nr_table_entries;

write_lock_bh(&queue->syn_wait_lock);
Expand Down

0 comments on commit 3eb4801

Please sign in to comment.