Skip to content

Commit

Permalink
rbd: set up watch before announcing disk
Browse files Browse the repository at this point in the history
We're ready to handle header object (refresh) events at the point we
call rbd_bus_add_dev().  Set up the watch request on the rbd image
header just after that, and after we've registered the devices for
the snapshots for the initial snapshot context.  Do this before
announce the disk as available for use.

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
  • Loading branch information
Alex Elder committed Oct 1, 2012
1 parent 12f0294 commit 3ee4001
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/block/rbd.c
Original file line number Diff line number Diff line change
Expand Up @@ -2646,16 +2646,17 @@ static ssize_t rbd_add(struct bus_type *bus,
if (rc)
goto err_out_bus;

rc = rbd_init_watch_dev(rbd_dev);
if (rc)
goto err_out_bus;

/* Everything's ready. Announce the disk to the world. */

add_disk(rbd_dev->disk);

pr_info("%s: added with size 0x%llx\n", rbd_dev->disk->disk_name,
(unsigned long long) rbd_dev->mapping.size);

rc = rbd_init_watch_dev(rbd_dev);
if (rc)
goto err_out_bus;

return count;

err_out_bus:
Expand Down

0 comments on commit 3ee4001

Please sign in to comment.