Skip to content

Commit

Permalink
phy: fix phy address bug
Browse files Browse the repository at this point in the history
PHYID returns 0xffff and not 0xffffffff when not found and in some
case(at91sam9263) 0x0. Maybe this patch could be useful.

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Giulio Benetti authored and David S. Miller committed Nov 16, 2008
1 parent 773c9c1 commit 3ee8238
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/phy/phy_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ struct phy_device * get_phy_device(struct mii_bus *bus, int addr)
if (r)
return ERR_PTR(r);

/* If the phy_id is all Fs, there is no device there */
if (0xffffffff == phy_id)
/* If the phy_id is all Fs or all 0s, there is no device there */
if ((0xffff == phy_id) || (0x00 == phy_id))
return NULL;

dev = phy_device_create(bus, addr, phy_id);
Expand Down

0 comments on commit 3ee8238

Please sign in to comment.