Skip to content

Commit

Permalink
[PATCH] MMC: wbsd cleanups
Browse files Browse the repository at this point in the history
This patch contains the following possible cleanups:
- make some needlessly global code static
- remove the unneeded global function DBG_REG

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Adrian Bunk authored and Russell King committed Jul 1, 2005
1 parent 6e6293d commit 3eee0d0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 29 deletions.
29 changes: 7 additions & 22 deletions drivers/mmc/wbsd.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,28 +54,6 @@
#define DBGF(x...) do { } while (0)
#endif

#ifdef CONFIG_MMC_DEBUG
void DBG_REG(int reg, u8 value)
{
int i;

printk(KERN_DEBUG "wbsd: Register %d: 0x%02X %3d '%c' ",
reg, (int)value, (int)value, (value < 0x20)?'.':value);

for (i = 7;i >= 0;i--)
{
if (value & (1 << i))
printk("x");
else
printk(".");
}

printk("\n");
}
#else
#define DBG_REG(r, v) do {} while (0)
#endif

/*
* Device resources
*/
Expand All @@ -92,6 +70,13 @@ MODULE_DEVICE_TABLE(pnp, pnp_dev_table);

#endif /* CONFIG_PNP */

static const int config_ports[] = { 0x2E, 0x4E };
static const int unlock_codes[] = { 0x83, 0x87 };

static const int valid_ids[] = {
0x7112,
};

#ifdef CONFIG_PNP
static unsigned int nopnp = 0;
#else
Expand Down
7 changes: 0 additions & 7 deletions drivers/mmc/wbsd.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,6 @@
* published by the Free Software Foundation.
*/

const int config_ports[] = { 0x2E, 0x4E };
const int unlock_codes[] = { 0x83, 0x87 };

const int valid_ids[] = {
0x7112,
};

#define LOCK_CODE 0xAA

#define WBSD_CONF_SWRST 0x02
Expand Down

0 comments on commit 3eee0d0

Please sign in to comment.